8000 mempool/lanes: Unit-test WRR iterator · Issue #3974 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

mempool/lanes: Unit-test WRR iterator #3974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #2803
hvanz opened this issue Sep 3, 2024 · 1 comment
Closed
Tracked by #2803

mempool/lanes: Unit-test WRR iterator #3974

hvanz opened this issue Sep 3, 2024 · 1 comment
Labels
mempool
Milestone
2024-Q3

Comments

@hvanz
Copy link
Member
hvanz commented Sep 3, 2024 •
edited
Loading

Main tests were done as part #3484. We need to check that the blocking and non-blocking iterators are tested properly and extend the unit tests if needed.
@hvanz hvanz mentioned this issue Sep 3, 2024
Closed
42 tasks
@hvanz hvanz changed the title Unit-test WRR [4 days] mempool/lanes: Unit-test WRR Sep 3, 2024
@hvanz hvanz added the mempool label Sep 3, 2024
@hvanz hvanz added this to CometBFT Sep 3, 2024
@github-project-automation github-project-automation bot moved this to Todo in CometBFT Sep 3, 2024
@hvanz hvanz changed the title mempool/lanes: Unit-test WRR mempool/lanes: Unit-test WRR iterator Sep 3, 2024
@hvanz
Copy link
Member Author
hvanz commented Sep 18, 2024 •
edited
Loading

We currently have 8 unit tests that cover blocking and non blocking iterators, with and without lanes. We have multiple concurrent blocking iterators with routines adding and removing txs.

On iterators.go commit 6f2c6599e, test coverage is 98.7%.

@hvanz hvanz closed this as completed Sep 18, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in CometBFT Sep 18, 2024
@hvanz hvanz added this to the 2024-Q3 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mempool
Projects
No open projects
CometBFT
Status: Done
Milestone
2024-Q3
Development

No branches or pull requests
1 participant
@hvanz
0