8000 mempool/lanes: Implement lanes in `CListMempool` · Issue #3484 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

mempool/lanes: Implement lanes in CListMempool #3484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #2803
hvanz opened this issue Jul 10, 2024 · 0 comments · Fixed by #3638
Closed
Tracked by #2803

mempool/lanes: Implement lanes in CListMempool #3484

hvanz opened this issue Jul 10, 2024 · 0 comments · Fixed by #3638
Assignees
Labels
enhancement New feature or request mempool
Milestone

Comments

@hvanz
Copy link
Member
hvanz commented Jul 10, 2024

Main component of the Lanes feature. It includes splitting the CList struct into multiple lists, mempool iterators for tx dissemination, reaping, and rechecking (implementing the WRR scheduling algorithm), and basic testing.

Requires #3475

Complementary tasks:

@hvanz hvanz added enhancement New feature or request mempool labels Jul 10, 2024
@hvanz hvanz added this to CometBFT Jul 10, 2024
@github-project-automation github-project-automation bot moved this to Todo in CometBFT Jul 10, 2024
@hvanz hvanz linked a pull request Aug 14, 2024 that will close this issue
4 tasks
@jmalicevic jmalicevic moved this from Todo to In Progress in CometBFT Sep 4, 2024
@jmalicevic jmalicevic added this to the 2024-Q3 milestone Sep 4, 2024
jmalicevic added a commit that referenced this issue Sep 6, 2024
Closes #3484 

- [X] To be rebased to `feature/mempoool-qos` once #3634  is merged. 

<!--

Please add a reference to the issue that this PR addresses and indicate
which
files are most critical to review. If it fully addresses a particular
issue,
please include "Closes #XXX" (where "XXX" is the issue number).

If this PR is non-trivial/large/complex, please ensure that you have
either
created an issue that the team's had a chance to respond to, or had some
discussion with the team prior to submitting substantial pull requests.
The team
can be reached via GitHub Discussions or the Cosmos Network Discord
server in
the #cometbft channel. GitHub Discussions is preferred over Discord as
it
allows us to keep track of conversations topically.
https://github.com/cometbft/cometbft/discussions

If the work in this PR is not aligned with the team's current
priorities, please
be advised that it may take some time before it is merged - especially
if it has
not yet been discussed with the team.

See the project board for the team's current priorities:
https://github.com/orgs/cometbft/projects/1

-->

---

#### PR checklist

- [X] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments

---------

Co-authored-by: hvanz <hernan.vanzetto@gmail.com>
Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com>
Co-authored-by: Sergio Mena <sergio@informal.systems>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from In Progress to Done in CometBFT Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mempool
Projects
No open projects
Status: Done
2 participants
0