8000 mempool/lanes: Query app for lane info · Issue #3475 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

mempool/lanes: Query app for lane info #3475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #2803
hvanz opened this issue Jul 10, 2024 · 1 comment · Fixed by #3634
Closed
Tracked by #2803

mempool/lanes: Query app for lane info #3475

hvanz opened this issue Jul 10, 2024 · 1 comment · Fixed by #3634
Labels
enhancement New feature or request mempool
Milestone
2024-Q3

Comments

@hvanz
Copy link
Member
hvanz commented Jul 10, 2024 •
edited
Loading

Implement part of the mempool initialisation to fetch lanes info as described in the ADR.

  • Add new function to fetch lanes info from the app via proxy.AppConnQuery
    • It should validate the received info (see here)
    • Possibly defined in the mempool package
  • Call the above function to fetch the lanes info in NewNode and pass the response to NewCListMempool.
    • Currently the Handshake function in internal/consensus/replay.go queries the app for info. We don't want to mix the mempool queries with consensus, so one option is to move proxyApp.Query().Info(...) outside of Handshake
    • Ideally we want to send an Info request to the app only once.

Requires #3502
@hvanz hvanz added enhancement New feature or request needs-triage This issue/PR has not yet been triaged by the team. mempool and removed needs-triage This issue/PR has not yet been triaged by the team. labels Jul 10, 2024
This was referenced Jul 10, 2024
Closed
Closed
Closed
@hvanz hvanz changed the title mempool/lanes: Implement querying the app for lanes info mempool/lanes: Query app for lane info Jul 11, 2024
@hvanz hvanz added this to CometBFT Jul 11, 2024
@github-project-automation github-project-automation bot moved this to Todo in CometBFT Jul 11, 2024
@hvanz
Copy link
Member Author
hvanz commented Jul 11, 2024

Cherry-pick commit from prototype branch: fetch lanes info from app

@jmalicevic jmalicevic mentioned this issue Aug 6, 2024
Merged
4 tasks
@hvanz hvanz linked a pull request Aug 7, 2024 that will close this issue
feat(mempool): query app for LanesInfo and pass to mempool constructor #3634
Merged
4 tasks
jmalicevic added a commit that referenced this issue Aug 14, 2024
@jmalicevic @hvanz @sergio-mena
feat(mempool): query app for LanesInfo and pass to mempool construc…
bf6377c 
…tor (#3634)

Closes #3475 

Adds InfoResponse to Handshake as argument.


Co-authored-by: hvanz <hernan.vanzetto@gmail.com>
Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com>
Co-authored-by: Sergio Mena <sergio@informal.systems>
@hvanz hvanz closed this as completed Aug 14, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in CometBFT Aug 14, 2024
@jmalicevic jmalicevic added this to the 2024-Q3 milestone Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request mempool
Projects
No open projects
CometBFT
Status: Done
Milestone
2024-Q3
2 participants
@jmalicevic @hvanz
0