8000 feat(lanes): Add non-blocking iterator by hvanz · Pull Request #3847 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(lanes): Add non-blocking iterator #3847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Aug 26, 2024

Conversation

hvanz
Copy link
Member
@hvanz hvanz commented Aug 23, 2024

For reaping and rechecking. Implements WRR scheduling.

Also moved all iterator tests to clist_iterator_test.go.


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

hvanz and others added 2 commits August 23, 2024 17:22
…3756)

We don't need to store the lane in a separate map. We can just extend
`mempoolTx` with a `lane` field.

---

#### PR checklist

- [ ] Tests written/updated
- [ ] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments
@hvanz hvanz added the mempool label Aug 23, 2024
@hvanz hvanz self-assigned this Aug 23, 2024
@hvanz hvanz marked this pull request as ready for review August 26, 2024 10:50
@hvanz hvanz requested review from a team as code owners August 26, 2024 10:50
Copy link
Contributor
@jmalicevic jmalicevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hernan , LGBTM 🚀

@jmalicevic jmalicevic added this to the 2024-Q3 milestone Aug 26, 2024 8000
hvanz and others added 2 commits August 26, 2024 12:59
Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com>
@hvanz hvanz merged commit 279ab9d into jasmina/3484-add-lanes-to-mempool Aug 26, 2024
34 checks passed
@hvanz hvanz deleted the hvanz/lanes-reap-iterator branch August 26, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants
0