fix(mempool/lanes): Do not reuse iterator when reaping #3996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a risk of race conditions on the iterator for reaping, as shown in the failed test TestBroadcastTxSync. We assumed that Reap methods are only called by
BlockExecutor, but this is not true. In particular,ReapMaxTxsis called by the RPC endpointUnconfirmedTxs.This PR creates a new iterator on every Reap call, instead of reusing only one.
Benchmarks with one reusable iterator and with an iterator created on each Reap call (this PR).