-
Notifications
You must be signed in to change notification settings - Fork 638
feat(mempool): add support for lanes #3638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jmalicevic
merged 113 commits into
feature/mempool-qos
from
jasmina/3484-add-lanes-to-mempool
Sep 6, 2024
Merged
feat(mempool): add support for lanes #3638
jmalicevic
merged 113 commits into
feature/mempool-qos
from
jasmina/3484-add-lanes-to-mempool
Sep 6, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etbft/cometbft into jasmina/3457-mempool-lanes-app-query
Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com>
Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com>
…cometbft/cometbft into jasmina/3457-mempool-lanes-app-query
… times. We need to clean the recheck struct at the end of rechecking.
sergio-mena
reviewed
Sep 4, 2024
sergio-mena
reviewed
Sep 4, 2024
sergio-mena
reviewed
Sep 4, 2024
sergio-mena
reviewed
Sep 4, 2024
sergio-mena
reviewed
Sep 4, 2024
sergio-mena
reviewed
Sep 4, 2024
sergio-mena
reviewed
Sep 4, 2024
sergio-mena
reviewed
Sep 4, 2024
melekes
reviewed
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work 👍
…4008) Addresses #3977 <!-- Please add a reference to the issue that this PR addresses and indicate which files are most critical to review. If it fully addresses a particular issue, please include "Closes #XXX" (where "XXX" is the issue number). If this PR is non-trivial/large/complex, please ensure that you have either created an issue that the team's had a chance to respond to, or had some discussion with the team prior to submitting substantial pull requests. The team can be reached via GitHub Discussions or the Cosmos Network Discord server in the #cometbft channel. GitHub Discussions is preferred over Discord as it allows us to keep track of conversations topically. https://github.com/cometbft/cometbft/discussions If the work in this PR is not aligned with the team's current priorities, please be advised that it may take some time before it is merged - especially if it has not yet been discussed with the team. See the project board for the team's current priorities: https://github.com/orgs/cometbft/projects/1 --> --- #### PR checklist - [x] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments
Co-authored-by: Sergio Mena <sergio@informal.systems>
sergio-mena
reviewed
Sep 6, 2024
sergio-mena
reviewed
Sep 6, 2024
sergio-mena
reviewed
Sep 6, 2024
sergio-mena
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks folks for this! 🙏
Way to go! 🚀
Co-authored-by: Sergio Mena <sergio@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3484
feature/mempoool-qos
once feat(mempool): query app forLanesInfo
and pass to mempool constructor #3634 is merged.PR checklist
.changelog
(we use unclog to manage our changelog)docs/
orspec/
) and code comments