8000 feat(e2e): Added e2e config to disable mempool lanes by jmalicevic · Pull Request #3993 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(e2e): Added e2e config to disable mempool lanes #3993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 139 commits into from
Sep 6, 2024

Conversation

jmalicevic
Copy link
Contributor
@jmalicevic jmalicevic commented Sep 3, 2024

Closes #4005 .

This PR adds:

  • one more test to confirm that the when lanes are disabled, the order of gossip and reaping is the same as in the old mempool version (done in feat(mempool/test): Add test to check order when lanes are disabled #4008)
  • a config flag for the e2e manifests to disable lanes. That way we can run a network that has lanes disabled on top of this version of Comet and make sure it works and its performance is not degraded by it.

hvanz and others added 30 commits August 5, 2024 14:52
…etbft/cometbft into jasmina/3457-mempool-lanes-app-query
Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com>
Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com>
…cometbft/cometbft into jasmina/3457-mempool-lanes-app-query
… times. We need to clean the recheck struct at the end of rechecking.
@jmalicevic
Copy link
Contributor Author

Blocked on #3638

Base automatically changed from jasmina/3484-add-lanes-to-mempool to feature/mempool-qos September 6, 2024 16:28
@jmalicevic jmalicevic merged commit 216bf5a into feature/mempool-qos Sep 6, 2024
33 checks passed
@jmalicevic jmalicevic deleted the jasmina/3977-lanes-tests branch September 6, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Related to our end-to-end tests mempool testing related to unit testing in general
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants
0