8000 mempool/lanes: add lanes to e2e tests · Issue #4005 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

mempool/lanes: add lanes to e2e tests #4005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
Tracked by #2803
hvanz opened this issue Sep 4, 2024 · 1 comment
Closed
3 tasks done
Tracked by #2803

mempool/lanes: add lanes to e2e tests #4005

hvanz opened this issue Sep 4, 2024 · 1 comment
Assignees
@jmalicevic
Labels
e2e Related to our end-to-end tests mempool
Milestone
2024-Q3

Comments

@hvanz
Copy link
Member
hvanz commented Sep 4, 2024 •
edited by jmalicevic
Loading

The e2e application now takes the lane from the transaction's payload. All e2e tests have lanes enabled by default.

We need some e2e tests with an app that don't implement lanes, that is, it returns nil lane values on Info and CheckTx requests.

Tasks:

  • Extend manifest to support no_lanes = true, so that the app does not implement lanes.
  • Add the no_lanes option to the e2e generator, so that nightly tests run also with no lanes (in particular, combined with abci_protocol = "tcp").
  • Add a lanes=[..] option to allow for custom lanes to be added to the manifest.
@hvanz hvanz added mempool e2e Related to our end-to-end tests labels Sep 4, 2024
@hvanz hvanz added this to CometBFT Sep 4, 2024
@github-project-automation github-project-automation bot moved this to Todo in CometBFT Sep 4, 2024
@hvanz hvanz mentioned this issue Sep 4, 2024
Closed
42 tasks
@hvanz hvanz changed the title test(mempool/lanes): add lanes to e2e tests mempool/lanes: add lanes to e2e tests Sep 4, 2024
@jmalicevic jmalicevic moved this from Todo to In Progress in CometBFT Sep 4, 2024
@jmalicevic jmalicevic self-assigned this Sep 4, 2024
@jmalicevic jmalicevic added this to the 2024-Q3 milestone Sep 4, 2024
@jmalicevic jmalicevic mentioned this issue Sep 5, 2024
Merged
jmalicevic added a commit that referenced this issue Sep 6, 2024
@jmalicevic @hvanz
@sergio-mena @mergify
feat(e2e): Added e2e config to disable mempool lanes (#3993)
216bf5a 
Closes #4005 .


This PR adds:
- ~~one more test to confirm that the when lanes are disabled, the order
of gossip and reaping is the same as in the old mempool version~~ (done
in #4008)
- a config flag for the e2e manifests to disable lanes. That way we can
run a network that has lanes disabled on top of this version of Comet
and make sure it works and its performance is not degraded by it.

---------

Co-authored-by: hvanz <hernan.vanzetto@gmail.com>
Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com>
Co-authored-by: Sergio Mena <sergio@informal.systems>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@jmalicevic
Copy link
Contributor

Closed by #3993

@github-project-automation github-project-automation bot moved this from In Progress to Done in CometBFT Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmalicevic jmalicevic

Labels
e2e Related to our end-to-end tests mempool
Projects
No open projects
CometBFT
Status: Done
Milestone
2024-Q3
Development

No branches or pull requests
2 participants
@jmalicevic @hvanz
0