8000 mempool/lanes: Write lane-specific unit tests · Issue #3977 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

mempool/lanes: Write lane-specific unit tests #3977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #2803
hvanz opened this issue Sep 3, 2024 · 1 comment
Closed
Tracked by #2803

mempool/lanes: Write lane-specific unit tests #3977

hvanz opened this issue Sep 3, 2024 · 1 comment
Assignees
@jmalicevic
Labels
mempool
Milestone
2024-Q4

Comments

@hvanz
Copy link
Member
hvanz commented Sep 3, 2024 •
edited
Loading

Depends on #3978 and #3980.

  • Allow kvstore to initialise with lanes (lanes = nil)
  • Unit test scenarios with nil as lanes (in clist_mempool_test.go)
@hvanz hvanz added the mempool label Sep 3, 2024
@hvanz hvanz added this to CometBFT Sep 3, 2024
@github-project-automation github-project-automation bot moved this to Todo in CometBFT Sep 3, 2024
@hvanz hvanz mentioned this issue Sep 3, 2024
Closed
42 tasks
@jmalicevic jmalicevic moved this from Todo to In Progress in CometBFT Sep 3, 2024
@jmalicevic jmalicevic added this to the 2024-Q4 milestone Sep 3, 2024
This was referenced Sep 3, 2024
Merged
Merged
jmalicevic added a commit that referenced this issue Sep 5, 2024
@jmalicevic
feat(mempool/test): Add test to check order when lanes are disabled (#…
d1b4fd8 
…4008)

Addresses  #3977 

<!--

Please add a reference to the issue that this PR addresses and indicate
which
files are most critical to review. If it fully addresses a particular
issue,
please include "Closes #XXX" (where "XXX" is the issue number).

If this PR is non-trivial/large/complex, please ensure that you have
either
created an issue that the team's had a chance to respond to, or had some
discussion with the team prior to submitting substantial pull requests.
The team
can be reached via GitHub Discussions or the Cosmos Network Discord
server in
the #cometbft channel. GitHub Discussions is preferred over Discord as
it
allows us to keep track of conversations topically.
https://github.com/cometbft/cometbft/discussions

If the work in this PR is not aligned with the team's current
priorities, please
be advised that it may take some time before it is merged - especially
if it has
not yet been discussed with the team.

See the project board for the team's current priorities:
https://github.com/orgs/cometbft/projects/1

-->

---

#### PR checklist

- [x] Tests written/updated
- [ ] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments
@jmalicevic
Copy link
Contributor

Closed with #3484 and #4008

@github-project-automation github-project-automation bot moved this from In Progress to Done in CometBFT Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmalicevic jmalicevic

Labels
mempool
Projects
No open projects
CometBFT
Status: Done
Milestone
2024-Q4
Development

No branches or pull requests
2 participants
@jmalicevic @hvanz
0