8000 main: Use unclog for changelog control by lasarojc · Pull Request #130 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

main: Use unclog for changelog control #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 18, 2023
Merged

main: Use unclog for changelog control #130

merged 11 commits into from
Jan 18, 2023

Conversation

lasarojc
Copy link
Contributor
@lasarojc lasarojc commented Jan 16, 2023 •
edited
Loading

Closes #105

PR checklist

  • Tests written/updated, or no tests needed
  • CHANGELOG_PENDING.md updated, or no changelog entry needed
  • Updated relevant documentation (docs/) and code comments, or no
    documentation updates needed

@lasarojc lasarojc linked an issue Jan 16, 2023 that may be closed by this pull request
Switch to using unclog for CometBFT's changelog #105
Closed
@lasarojc
Copy link
Contributor Author

We need to update the issue template not to reference CHANGELOG_PENDING.md

@lasarojc
Copy link
Contributor Author

Pending updates to unclog for issue template and proper linking to issues, but these should not block reviews.

@lasarojc lasarojc marked this pull request as ready for review January 17, 2023 14:18
@lasarojc lasarojc requested a review from a team as a code owner January 17, 2023 14:18
@lasarojc lasarojc changed the title Use unclog for changelog control main: Use unclog for changelog control Jan 17, 2023
thanethomson
thanethomson approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor
@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be good to generate the CHANGELOG.md file here before merging this PR, just so that there's something there in the meantime. We can always regenerate later on.

lasarojc and others added 4 commits January 18, 2023 07:12
@lasarojc
fixing issue number
0324853
@lasarojc @thanethomson
Update .changelog/epilogue.md
7677827 
Co-authored-by: Thane Thomson <connect@thanethomson.com>
@lasarojc @thanethomson
Update .changelog/epilogue.md
d91b86f 
Co-authored-by: Thane Thomson <connect@thanethomson.com>
@lasarojc
Merge branch 'main' into lasarojc/105-use-unclog
3093cd7
@lasarojc
Copy link
Contributor Author
lasarojc commented Jan 18, 2023 •
edited
Loading

The corresponding 0.37.x change is merged, with corresponding log. They are marked as unreleased, though. How do we show those changes here?

@lasarojc lasarojc merged commit cf903eb into main Jan 18, 2023
@lasarojc lasarojc deleted the lasarojc/105-use-unclog branch January 18, 2023 13:25
@cason cason mentioned this pull request Feb 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thanethomson thanethomson thanethomson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to using unclog for CometBFT's changelog
2 participants
@lasarojc @thanethomson
0