mempool: Add missing gauge constructor for size_bytes metric
#1642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thane Thomson <connect@thanethomson.com>
hvanz
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the nightlies on #1641 picked up a segmentation fault which I traced to the fact that we're not constructing a gauge related to the
size_bytesmetric (from #1568). In the v0.34 line, we need to manually construct these gauges.Running the E2E nightlies manually on this branch to validate that this fixes the problem: https://github.com/cometbft/cometbft/actions/runs/6897189522
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments