docs: various small improvements (part 2) (backport #1683) #1685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* docs: fix the number of connections CometBFT opens to the ABCI app * docs: fix link formatting * docs: make it explicit that default is TCP for ABCI * docs: replace 'supermajority' with 2/3+ 2/3+ is easier to understand. also this is the first time the reader is seeing the word 'supermajority', which might be confusing without the defition. The defition for supermajority is absent (maybe it's in the spec though) * add a link to jq * suggestions from Lasaro (cherry picked from commit 96abada) # Conflicts: # docs/app-dev/indexing-transactions.md # docs/core/block-structure.md
melekes
approved these changes
Nov 23, 2023
nivasan1
pushed a commit
to nivasan1/cometbft
that referenced
this pull request
Nov 28, 2023
…ometbft#1685) * docs: various small improvements (part 2) (cometbft#1683) * docs: fix the number of connections CometBFT opens to the ABCI app * docs: fix lin 7D6A k formatting * docs: make it explicit that default is TCP for ABCI * docs: replace 'supermajority' with 2/3+ 2/3+ is easier to understand. also this is the first time the reader is seeing the word 'supermajority', which might be confusing without the defition. The defition for supermajority is absent (maybe it's in the spec though) * add a link to jq * suggestions from Lasaro (cherry picked from commit 96abada) # Conflicts: # docs/app-dev/indexing-transactions.md # docs/core/block-structure.md * fixes after merge --------- Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #1683 done by Mergify.
Cherry-pick of 96abada has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com