8000 ci: fix generated code check in 0.37.x by lasarojc · Pull Request #179 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ci: fix generated code check in 0.37.x #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2023
Merged

ci: fix generated code check in 0.37.x #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffc9521
Updating go version used for make-proto gen in CI to match local results
lasarojc Jan 23, 2023
b322b33
Updating the proto to match the update to go 1.19
lasarojc Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions .github/workflows/check-generated.yml
View file
Open in desktop
10000
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ name: Check generated code
on:
pull_request:
branches:
- main
- v0.37.x

permissions:
contents: read
Expand Down Expand Up @@ -48,7 +48,7 @@ jobs:
steps:
- uses: actions/setup-go@v3
with:
go-version: "1.18"
go-version: "1.19"

- uses: actions/checkout@v3
with:
Expand All @@ -58,15 +58,6 @@ jobs:
run: |
set -euo pipefail

# Install buf and gogo tools, so that differences that arise from
# toolchain differences are also caught.
readonly tools="$(mktemp -d)"
export PATH="${PATH}:${tools}/bin"
export GOBIN="${tools}/bin"

go install github.com/bufbuild/buf/cmd/buf
go install github.com/cosmos/gogoproto/protoc-gen-gogofaster@latest

make proto-gen

if ! git diff --stat --exit-code ; then
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/proto-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: Protobuf Lint
name: Protobuf Lint
on:
pull_request:
paths:
- 'proto/**'
push:
branches:
- main
- v0.37.x
paths:
- 'proto/**'

Expand All @@ -16,6 +16,9 @@ jobs:
steps:
- uses: actions/checkout@v3
- uses: bufbuild/buf-setup-action@v1.12.0
with:
github_token: ${{ secrets.BUF_GITHUB_API_TOKEN }}
buf_api_token: ${{ secrets.BUF_API_TOKEN }}
- uses: bufbuild/buf-lint-action@v1
with:
input: 'proto'
1 change: 1 addition & 0 deletions abci/types/types.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions proto/tendermint/crypto/keys.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions proto/tendermint/mempool/types.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions proto/tendermint/p2p/conn.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions proto/tendermint/statesync/types.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0