8000 fix link by lasarojc · Pull Request #296 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix link #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 9, 2023
Merged

fix link #296

merged 3 commits into from
Feb 9, 2023

Conversation

lasarojc
Copy link
Contributor
@lasarojc lasarojc commented Feb 9, 2023

Fixes a badly formatted link.

PR checklist

  • Tests written/updated, or no tests needed
  • CHANGELOG_PENDING.md updated, or no changelog entry needed
  • Updated relevant documentation (docs/) and code comments, or no
    documentation updates needed

@lasarojc lasarojc added backport-to-v0.34.x Tell Mergify to backport the PR to v0.34.x backport-to-v0.37.x Tell Mergify to backport the PR to v0.37.x rename Renaming our fork labels Feb 9, 2023
@lasarojc lasarojc requested a review from a team as a code owner February 9, 2023 16:05
@lasarojc lasarojc self-assigned this Feb 9, 2023
@lasarojc lasarojc added the docs label Feb 9, 2023
@thanethomson thanethomson added documentation Improvements or additions to documentation and removed docs labels Feb 9, 2023
@andynog andynog removed the backport-to-v0.34.x Tell Mergify to backport the PR to v0.34.x label Feb 9, 2023
@andynog
Copy link
Contributor
andynog commented Feb 9, 2023

lgtm, but we should not backport to v0.34 since we don't have the architecture folder in the docs in this release
https://github.com/cometbft/cometbft/tree/v0.34.x/docs

@sergio-mena sergio-mena removed the backport-to-v0.37.x Tell Mergify to backport the PR to v0.37.x label Feb 9, 2023
@cason
Copy link
Contributor
cason commented Feb 9, 2023 •
edited
Loading

Hey, before you merge, I think the same malformed link is also present in the RFCs' README file: https://github.com/cometbft/cometbft/blob/main/docs/rfc/README.md

@sergio-mena sergio-mena added the backport-to-v0.37.x Tell Mergify to backport the PR to v0.37.x label Feb 9, 2023
@andynog
Copy link
Contributor
andynog commented Feb 9, 2023

Hey, before you merge, I think the same malformed link is also present in the RFCs' README file: https://github.com/cometbft/cometbft/blob/main/docs/rfc/README.md

thanks @cason I can fix that

@andynog andynog merged commit f1ce1c5 into main Feb 9, 2023
@andynog andynog deleted the lasarojc-patch-3 branch February 9, 2023 20:11
@mergify mergify bot mentioned this pull request Feb 9, 2023
Merged
mergify bot pushed a commit that referenced this pull request Feb 9, 2023
@lasarojc @andynog @mergify
fix link (#296)
f28280c 
* fix link

* fixing broken link (#296)

---------

Co-authored-by: Andy Nogueira <me@andynogueira.dev>
(cherry picked from commit f1ce1c5)
andynog pushed a commit that referenced this pull request Feb 9, 2023
@mergify @lasarojc
fix link (#296) (#303)
24fe1cc 
* fix link

* fixing broken link (#296)

---------

Co-authored-by: Andy Nogueira <me@andynogueira.dev>
(cherry picked from commit f1ce1c5)

Co-authored-by: Lasaro <lasaro@informal.systems>
@faddat faddat mentioned this pull request Jan 5, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cason cason cason approved these changes

@sergio-mena sergio-mena sergio-mena approved these changes

Assignees

@lasarojc lasarojc

Labels
backport-to-v0.37.x Tell Mergify to backport the PR to v0.37.x documentation Improvements or additions to documentation rename Renaming our fork
Projects
No open projects
CometBFT 2023
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lasarojc @andynog @cason @sergio-mena @thanethomson
0