perf(types): 3x speedup MakePartSet #3117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok to backport to 1.x and 38.x ? |
ValarDragon
added a commit
to osmosis-labs/cometbft
that referenced
this pull request
May 29, 2024
<!-- Please add a reference to the issue that this PR addresses and indicate which files are most critical to review. If it fully addresses a particular issue, please include "Closes #XXX" (where "XXX" is the issue number). If this PR is non-trivial/large/complex, please ensure that you have either created an issue that the team's had a chance to respond to, or had some discussion with the team prior to submitting substantial pull requests. The team can be reached via GitHub Discussions or the Cosmos Network Discord server in the #cometbft channel. GitHub Discussions is preferred over Discord as it allows us to keep track of conversations topically. https://github.com/cometbft/cometbft/discussions If the work in this PR is not aligned with the team's current priorities, please be advised that it may take some time before it is merged - especially if it has not yet been discussed with the team. See the project board for the team's current priorities: https://github.com/orgs/cometbft/projects/1 --> This PR adds some benchmarks, and significantly speeds up types.MakePartSet, and Partset.AddPart. (Used by the block proposer, and every consensus instance) It does so by doing two things: - Saving mutexes on the newly created bit array, by defaulting every value to True (rather than setting it in a loop that goes through a mutex) - Uses the same hash object throughout, and avoids an extra copy of every leaf. (main speedup) I do the same hash optimization for proof.Verify, which is used in the add block part codepath for both the proposer and every full node. New: ``` BenchmarkMakePartSet/nParts=1-12 38616 29817 ns/op 568 B/op 12 allocs/op BenchmarkMakePartSet/nParts=2-12 19888 59866 ns/op 1000 B/op 22 allocs/op BenchmarkMakePartSet/nParts=3-12 12979 95691 ns/op 1528 B/op 33 allocs/op BenchmarkMakePartSet/nParts=4-12 8688 128192 ns/op 2024 B/op 44 allocs/op BenchmarkMakePartSet/nParts=5-12 7308 155224 ns/op 2888 B/op 57 allocs/op ``` Old: ``` BenchmarkMakePartSet/nParts=1-12 16647 106545 ns/op 74169 B/op 12 allocs/op BenchmarkMakePartSet/nParts=2-12 10000 106361 ns/op 148329 B/op 23 allocs/op BenchmarkMakePartSet/nParts=3-12 6992 337644 ns/op 222587 B/op 35 allocs/op BenchmarkMakePartSet/nParts=4-12 3488 480109 ns/op 296811 B/op 47 allocs/op BenchmarkMakePartSet/nParts=5-12 2228 557768 ns/op 371404 B/op 61 allocs/op ``` System wide, this is definitely not our issue (looks like roughly .1ms per blockpart), but still definitely useful time to remove --- - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
ValarDragon
added a commit
to osmosis-labs/cometbft
that referenced
this pull request
May 29, 2024
perf(types): 3x speedup MakePartSet (cometbft#3117)
mergify bot
pushed a commit
to osmosis-labs/cometbft
that referenced
this pull request
May 29, 2024
<!-- Please add a reference to the issue that this PR addresses and indicate which files are most critical to review. If it fully addresses a particular issue, please include "Closes #XXX" (where "XXX" is the issue number). If this PR is non-trivial/large/complex, please ensure that you have either created an issue that the team's had a chance to respond to, or had some discussion with the team prior to submitting substantial pull requests. The team can be reached via GitHub Discussions or the Cosmos Network Discord server in the #cometbft channel. GitHub Discussions is preferred over Discord as it allows us to keep track of conversations topically. https://github.com/cometbft/cometbft/discussions If the work in this PR is not aligned with the team's current priorities, please be advised that it may take some time before it is merged - especially if it has not yet been discussed with the team. See the project board for the team's current priorities: https://github.com/orgs/cometbft/projects/1 --> This PR adds some benchmarks, and significantly speeds up types.MakePartSet, and Partset.AddPart. (Used by the block proposer, and every consensus instance) It does so by doing two things: - Saving mutexes on the newly created bit array, by defaulting every value to True (rather than setting it in a loop that goes through a mutex) - Uses the same hash object throughout, and avoids an extra copy of every leaf. (main speedup) I do the same hash optimization for proof.Verify, which is used in the add block part codepath for both the proposer and every full node. New: ``` BenchmarkMakePartSet/nParts=1-12 38616 29817 ns/op 568 B/op 12 allocs/op BenchmarkMakePartSet/nParts=2-12 19888 59866 ns/op 1000 B/op 22 allocs/op BenchmarkMakePartSet/nParts=3-12 12979 95691 ns/op 1528 B/op 33 allocs/op BenchmarkMakePartSet/nParts=4-12 8688 128192 ns/op 2024 B/op 44 allocs/op BenchmarkMakePartSet/nParts=5-12 7308 155224 ns/op 2888 B/op 57 allocs/op ``` Old: ``` BenchmarkMakePartSet/nParts=1-12 16647 106545 ns/op 74169 B/op 12 allocs/op BenchmarkMakePartSet/nParts=2-12 10000 106361 ns/op 148329 B/op 23 allocs/op BenchmarkMakePartSet/nParts=3-12 6992 337644 ns/op 222587 B/op 35 allocs/op BenchmarkMakePartSet/nParts=4-12 3488 480109 ns/op 296811 B/op 47 allocs/op BenchmarkMakePartSet/nParts=5-12 2228 557768 ns/op 371404 B/op 61 allocs/op ``` System wide, this is definitely not our issue (looks like roughly .1ms per blockpart), but still definitely useful time to remove --- - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec (cherry picked from commit 7b1c1f8)
ValarDragon
added a commit
to osmosis-labs/cometbft
that referenced
this pull request
May 31, 2024
…pr-83 perf(types): 3x speedup MakePartSet (cometbft#3117) (backport #83)
itsdevbear
pushed a commit
to berachain/cometbft
that referenced
this pull request
Jul 4, 2024
<!-- Please add a reference to the issue that this PR addresses and indicate which files are most critical to review. If it fully addresses a particular issue, please include "Closes #XXX" (where "XXX" is the issue number). If this PR is non-trivial/large/complex, please ensure that you have either created an issue that the team's had a chance to respond to, or had some discussion with the team prior to submitting substantial pull requests. The team can be reached via GitHub Discussions or the Cosmos Network Discord server in the #cometbft channel. GitHub Discussions is preferred over Discord as it allows us to keep track of conversations topically. https://github.com/cometbft/cometbft/discussions If the work in this PR is not aligned with the team's current priorities, please be advised that it may take some time before it is merged - especially if it has not yet been discussed with the team. See the project board for the team's current priorities: https://github.com/orgs/cometbft/projects/1 --> This PR adds some benchmarks, and significantly speeds up types.MakePartSet, and Partset.AddPart. (Used by the block proposer, and every consensus instance) It does so by doing two things: - Saving mutexes on the newly created bit array, by defaulting every value to True (rather than setting it in a loop that goes through a mutex) - Uses the same hash object throughout, and avoids an extra copy of every leaf. (main speedup) I do the same hash optimization for proof.Verify, which is used in the add block part codepath for both the proposer and every full node. New: ``` BenchmarkMakePartSet/nParts=1-12 38616 29817 ns/op 568 B/op 12 allocs/op BenchmarkMakePartSet/nParts=2-12 19888 59866 ns/op 1000 B/op 22 allocs/op BenchmarkMakePartSet/nParts=3-12 12979 95691 ns/op 1528 B/op 33 allocs/op BenchmarkMakePartSet/nParts=4-12 8688 128192 ns/op 2024 B/op 44 allocs/op BenchmarkMakePartSet/nParts=5-12 7308 155224 ns/op 2888 B/op 57 allocs/op ``` Old: ``` BenchmarkMakePartSet/nParts=1-12 16647 106545 ns/op 74169 B/op 12 allocs/op BenchmarkMakePartSet/nParts=2-12 10000 106361 ns/op 148329 B/op 23 allocs/op BenchmarkMakePartSet/nParts=3-12 6992 337644 ns/op 222587 B/op 35 allocs/op BenchmarkMakePartSet/nParts=4-12 3488 480109 ns/op 296811 B/op 47 allocs/op BenchmarkMakePartSet/nParts=5-12 2228 557768 ns/op 371404 B/op 61 allocs/op ``` System wide, this is definitely not our issue (looks like roughly .1ms per blockpart), but still definitely useful time to remove --- - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec (cherry picked from commit 7b1c1f8)
|
@mergify backport v1.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
<!-- Please add a reference to the issue that this PR addresses and indicate which files are most critical to review. If it fully addresses a particular issue, please include "Closes #XXX" (where "XXX" is the issue number). If this PR is non-trivial/large/complex, please ensure that you have either created an issue that the team's had a chance to respond to, or had some discussion with the team prior to submitting substantial pull requests. The team can be reached via GitHub Discussions or the Cosmos Network Discord server in the #cometbft channel. GitHub Discussions is preferred over Discord as it allows us to keep track of conversations topically. https://github.com/cometbft/cometbft/discussions If the work in this PR is not aligned with the team's current priorities, please be advised that it may take some time before it is merged - especially if it has not yet been discussed with the team. See the project board for the team's current priorities: https://github.com/orgs/cometbft/projects/1 --> This PR adds some benchmarks, and significantly speeds up types.MakePartSet, and Partset.AddPart. (Used by the block proposer, and every consensus instance) It does so by doing two things: - Saving mutexes on the newly created bit array, by defaulting every value to True (rather than setting it in a loop that goes through a mutex) - Uses the same hash object throughout, and avoids an extra copy of every leaf. (main speedup) I do the same hash optimization for proof.Verify, which is used in the add block part codepath for both the proposer and every full node. New: ``` BenchmarkMakePartSet/nParts=1-12 38616 29817 ns/op 568 B/op 12 allocs/op BenchmarkMakePartSet/nParts=2-12 19888 59866 ns/op 1000 B/op 22 allocs/op BenchmarkMakePartSet/nParts=3-12 12979 95691 ns/op 1528 B/op 33 allocs/op BenchmarkMakePartSet/nParts=4-12 8688 128192 ns/op 2024 B/op 44 allocs/op BenchmarkMakePartSet/nParts=5-12 7308 155224 ns/op 2888 B/op 57 allocs/op ``` Old: ``` BenchmarkMakePartSet/nParts=1-12 16647 106545 ns/op 74169 B/op 12 allocs/op BenchmarkMakePartSet/nParts=2-12 10000 106361 ns/op 148329 B/op 23 allocs/op BenchmarkMakePartSet/nParts=3-12 6992 337644 ns/op 222587 B/op 35 allocs/op BenchmarkMakePartSet/nParts=4-12 3488 480109 ns/op 296811 B/op 47 allocs/op BenchmarkMakePartSet/nParts=5-12 2228 557768 ns/op 371404 B/op 61 allocs/op ``` System wide, this is definitely not our issue (looks like roughly .1ms per blockpart), but still definitely useful time to remove --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec (cherry picked from commit f94dea5) # Conflicts: # .changelog/unreleased/improvements/3117-significantly-speedup-make-partset.md
4 tasks
melekes
added a commit
that referenced
this pull request
Jul 10, 2024
This PR adds some benchmarks, and significantly speeds up types.MakePartSet, and Partset.AddPart. (Used by the block proposer, and every consensus instance) It does so by doing two things: - Saving mutexes on the newly created bit array, by defaulting every value to True (rather than setting it in a loop that goes through a mutex) - Uses the same hash object throughout, and avoids an extra copy of every leaf. (main speedup) I do the same hash optimization for proof.Verify, which is used in the add block part codepath for both the proposer and every full node. New: ``` BenchmarkMakePartSet/nParts=1-12 38616 29817 ns/op 568 B/op 12 allocs/op BenchmarkMakePartSet/nParts=2-12 19888 59866 ns/op 1000 B/op 22 allocs/op BenchmarkMakePartSet/nParts=3-12 12979 95691 ns/op 1528 B/op 33 allocs/op BenchmarkMakePartSet/nParts=4-12 8688 128192 ns/op 2024 B/op 44 allocs/op BenchmarkMakePartSet/nParts=5-12 7308 155224 ns/op 2888 B/op 57 allocs/op ``` Old: ``` BenchmarkMakePartSet/nParts=1-12 16647 106545 ns/op 74169 B/op 12 allocs/op BenchmarkMakePartSet/nParts=2-12 10000 106361 ns/op 148329 B/op 23 allocs/op BenchmarkMakePartSet/nParts=3-12 6992 337644 ns/op 222587 B/op 35 allocs/op BenchmarkMakePartSet/nParts=4-12 3488 480109 ns/op 296811 B/op 47 allocs/op BenchmarkMakePartSet/nParts=5-12 2228 557768 ns/op 371404 B/op 61 allocs/op ``` System wide, this is definitely not our issue (looks like roughly .1ms per blockpart), but still definitely useful time to remove --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclo 8000 g](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #3117 done by [Mergify](https://mergify.com). --------- Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
ValarDragon
added a commit
to osmosis-labs/cometbft
that referenced
this pull request
Aug 19, 2024
…t#3470) This PR adds some benchmarks, and significantly speeds up types.MakePartSet, and Partset.AddPart. (Used by the block proposer, and every consensus instance) It does so by doing two things: - Saving mutexes on the newly created bit array, by defaulting every value to True (rather than setting it in a loop that goes through a mutex) - Uses the same hash object throughout, and avoids an extra copy of every leaf. (main speedup) I do the same hash optimization for proof.Verify, which is used in the add block part codepath for both the proposer and every full node. New: ``` BenchmarkMakePartSet/nParts=1-12 38616 29817 ns/op 568 B/op 12 allocs/op BenchmarkMakePartSet/nParts=2-12 19888 59866 ns/op 1000 B/op 22 allocs/op BenchmarkMakePartSet/nParts=3-12 12979 95691 ns/op 1528 B/op 33 allocs/op BenchmarkMakePartSet/nParts=4-12 8688 128192 ns/op 2024 B/op 44 allocs/op BenchmarkMakePartSet/nParts=5-12 7308 155224 ns/op 2888 B/op 57 allocs/op ``` Old: ``` BenchmarkMakePartSet/nParts=1-12 16647 106545 ns/op 74169 B/op 12 allocs/op BenchmarkMakePartSet/nParts=2-12 10000 106361 ns/op 148329 B/op 23 allocs/op BenchmarkMakePartSet/nParts=3-12 6992 337644 ns/op 222587 B/op 35 allocs/op BenchmarkMakePartSet/nParts=4-12 3488 480109 ns/op 296811 B/op 47 allocs/op BenchmarkMakePartSet/nParts=5-12 2228 557768 ns/op 371404 B/op 61 allocs/op ``` System wide, this is definitely not our issue (looks like roughly .1ms per blockpart), but still definitely useful time to remove --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request cometbft#3117 done by [Mergify](https://mergify.com). --------- Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some benchmarks, and significantly speeds up types.MakePartSet, and Partset.AddPart. (Used by the block proposer, and every consensus instance) It does so by doing two things:
I do the same hash optimization for proof.Verify, which is used in the add block part codepath for both the proposer and every full node.
New:
Old:
System wide, this is definitely not our issue (looks like roughly .1ms per blockpart), but still definitely useful time to remove
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments