Allow inclusion of repository in the tag name, so ghcr and dockerub c… #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an be used, including in the same experiment
Codecov ReportBase: 48.40% // Head: 48.37% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v0.34.x #345 +/- ##
===========================================
- Coverage 48.40% 48.37% -0.04%
===========================================
Files 280 280
Lines 49887 49908 +21
===========================================
- Hits 24150 24145 -5
- Misses 23878 23900 +22
- Partials 1859 1863 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…ersions. Uses multiversion to set UpgradeVersion.
sergio-mena
reviewed
Feb 20, 2023
lasarojc
added a commit
that referenced
this pull request
Feb 21, 2023
#345) * Allow inclusion of repository in the tag name, so ghcr and dockerub can be used, including in the same experiment * Moves UpgradeVersion to Node, so nodes can be upgraded to different versions. Uses multiversion to set UpgradeVersion. * Updates the path for the local-version image. * Do not use yoda conditions. * Use the right code coverage definitions * Revert use of . We will only do a maximum of 2 versions per run
lasarojc
added a commit
that referenced
this pull request
Feb 21, 2023
#345) * Allow inclusion of repository in the tag name, so ghcr and dockerub can be used, including in the same experiment * Moves UpgradeVersion to Node, so nodes can be upgraded to different versions. Uses multiversion to set UpgradeVersion. * Updates the path for the local-version image. * Do not use yoda conditions. * Use the right code coverage definitions * Revert use of . We will only do a maximum of 2 versions per run
3 tasks
lasarojc
added a commit
that referenced
this pull request
Feb 21, 2023
#345) (#362) * Allow inclusion of repository in the tag name, so ghcr and dockerub can be used, including in the same experiment * Moves UpgradeVersion to Node, so nodes can be upgraded to different versions. Uses multiversion to set UpgradeVersion. * Updates the path for the local-version image. * Do not use yoda conditions. * Use the right code coverage definitions * Revert use of . We will only do a maximum of 2 versions per run
mergify bot
pushed a commit
that referenced
this pull request
Feb 21, 2023
#345) (#362) * Allow inclusion of repository in the tag name, so ghcr and dockerub can be used, including in the same experiment * Moves UpgradeVersion to Node, so nodes can be upgraded to different versions. Uses multiversion to set UpgradeVersion. * Updates the path for the local-version image. * Do not use yoda conditions. * Use the right code coverage definitions * Revert use of . We will only do a maximum of 2 versions per run (cherry picked from commit 45a08f3)
lasarojc
added a commit
that referenced
this pull request
Feb 21, 2023
#345) (#362) (#363) * Allow inclusion of repository in the tag name, so ghcr and dockerub can be used, including in the same experiment * Moves UpgradeVersion to Node, so nodes can be upgraded to different versions. Uses multiversion to set UpgradeVersion. * Updates the path for the local-version image. * Do not use yoda conditions. * Use the right code coverage definitions * Revert use of . We will only do a maximum of 2 versions per run (cherry picked from commit 45a08f3) Co-authored-by: Lasaro <lasaro@informal.systems>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…an be used, including in the same experiment
Should be ported to 0.37 and main.
PR checklist
.changelog(we useunclog to manage our changelog)
docs/orspec/) and code comments