QA report for 0.37.x alpha3 #376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… begin time in the right format, use left end of experiment window instead of the right end.
thanethomson
approved these changes
Feb 24, 2023
mergify bot
pushed a commit
that referenced
this pull request
Feb 25, 2023
[QA docs README rendered](https://github.com/cometbft/cometbft/blob/lasarojc/qa_0.37.x-alpha3/docs/qa/README.md) --- #### PR checklist - [x] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit d73e622)
sergio-mena
reviewed
Feb 26, 2023
There was a problem hiding this comment.
This looks really good. I'll try to run the updated scripts on the baseline data (as we did for v0.34.x so the comparison is even clearer.
UPDATE: #395
3 tasks
lasarojc
added a commit
that referenced
this pull request
Feb 26, 2023
[QA docs README rendered](https://github.com/cometbft/cometbft/blob/lasarojc/qa_0.37.x-alpha3/docs/qa/README.md) --- #### PR checklist - [x] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit d73e622) Co-authored-by: Lasaro <lasaro@informal.systems>
mergify bot
pushed a commit
that referenced
this pull request
Feb 27, 2023
Contributes to #93 and #41 [Rendered](https://github.com/cometbft/cometbft/blob/sergio/qa_0.37.x-alpha3_baseline_plots/docs/qa/v037/CometBFT.md) Complementary to #376 (and analogous to what we did for CometBFT `v0.34.x` QA) this PR re-plots the baseline results, obtained in Oct 2022, using the newly developed python scripts. The goal is to ease visual comparison between CometBFT `v0.37.x` and Tendermint Core baseline results when looking at the report. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments
mergify bot
pushed a commit
that referenced
this pull request
Feb 27, 2023
Contributes to #93 and #41 [Rendered](https://github.com/cometbft/cometbft/blob/sergio/qa_0.37.x-alpha3_baseline_plots/docs/qa/v037/CometBFT.md) Complementary to #376 (and analogous to what we did for CometBFT `v0.34.x` QA) this PR re-plots the baseline results, obtained in Oct 2022, using the newly developed python scripts. The goal is to ease visual comparison between CometBFT `v0.37.x` and Tendermint Core baseline results when looking at the report. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit c67d2f7)
sergio-mena
added a commit
that referenced
this pull request
Feb 27, 2023
Contributes to #93 and #41 [Rendered](https://github.com/cometbft/cometbft/blob/sergio/qa_0.37.x-alpha3_baseline_plots/docs/qa/v037/CometBFT.md) Complementary to #376 (and analogous to what we did for CometBFT `v0.34.x` QA) this PR re-plots the baseline results, obtained in Oct 2022, using the newly developed python scripts. The goal is to ease visual comparison between CometBFT `v0.37.x` and Tendermint Core baseline results when looking at the report. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit c67d2f7) Co-authored-by: Sergio Mena <sergio@informal.systems>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #93 and #41
QA docs README rendered
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments