8000 Short-term fix for `needProofBlock` problem based on the `main` branch by adizere · Pull Request #387 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Short-term fix for needProofBlock problem based on the main branch #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 27, 2023
Merged

Short-term fix for needProofBlock problem based on the main branch #387

merged 3 commits into from
Feb 27, 2023

Conversation

adizere
Copy link
Member
@adizere adizere commented Feb 24, 2023 •
edited
Loading

Ports the changes from PR #386 based off the main branch. To be backported to v0.37.*.

Ref: #402 and #370

PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

@adizere adizere added the backport-to-v0.37.x Tell Mergify to backport the PR to v0.37.x label Feb 24, 2023
@adizere adizere requested a review from a team as a code owner February 24, 2023 18:43
@adizere adizere changed the title Adi/quick fix 370 main Short-term fix for needProofBlock problem based on the main branch Feb 24, 2023
@adizere adizere merged commit 28b130f into main Feb 27, 2023
@adizere adizere deleted the adi/quick_fix_370_main branch February 27, 2023 09:39
mergify bot pushed a commit that referenced this pull request Feb 27, 2023
@adizere @mergify
Short-term fix for needProofBlock problem based on the main branch (
700522e 
#387)

* changelog

* Added log and short-circuit in needProofBlock

(cherry picked from commit 28b130f)
@mergify mergify bot mentioned this pull request Feb 27, 2023
Merged
adizere added a commit that referenced this pull request Feb 28, 2023
@mergify @adizere @lasarojc
Short-term fix for needProofBlock problem based on the main branch (
bcf288c 
#387) (#400)

* changelog

* Added log and short-circuit in needProofBlock

(cherry picked from commit 28b130f)

Co-authored-by: Adi Seredinschi <adizere@gmail.com>
Co-authored-by: Lasaro <lasaro@informal.systems>
@faddat faddat mentioned this pull request Jan 5, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thanethomson thanethomson thanethomson approved these changes

@cason cason cason approved these changes

@sergio-mena sergio-mena sergio-mena approved these changes

Assignees
No one assigned
Labels
backport-to-v0.37.x Tell Mergify to backport the PR to v0.37.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adizere @thanethomson @cason @sergio-mena
0