txindex v0.37.x: Enable the indexer to parse slashes in query #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasarojc
reviewed
Feb 24, 2023
lasarojc
reviewed
Feb 24, 2023
lasarojc
approved these changes
Feb 24, 2023
5 tasks
thanethomson
approved these changes
Feb 24, 2023
.changelog/unreleased/bug-fixes/382-txindexer-fix-slash-parsing.md
Outdated
Show resolved
Hide resolved
…g.md Co-authored-by: Thane Thomson <connect@thanethomson.com>
jmalicevic
added a commit
that referenced
this pull request
Feb 28, 2023
* txindexer handles slashes in event value * Update .changelog/unreleased/bug-fixes/382-txindexer-fix-slash-parsing.md Co-authored-by: Thane Thomson <connect@thanethomson.com> --------- Co-authored-by: Thane Thomson <connect@thanethomson.com>
3 tasks
jmalicevic
added a commit
that referenced
this pull request
Mar 21, 2023
* v0.37.x:state/kvindexer: port 0.34 query fix (#77) Backport of #77 from 0.37 and #382 to handle slashes * state/kvindexer: associate event attributes with events (#9759) * By event search is now default behaviour. Including fixes from PRs added to 0.34 --------- Co-authored-by: Lasaro <lasaro@gmail.com> Co-authored-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Sergio Mena <sergio@informal.systems>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transaction indexer indexes transaction events by creating a custom key containing the following:
These elements are separated with a '/'. This however causes problems when the value (over which we have no control), contains a '/' . This PR fixes this by making sure to isolate the element containing the value.
The code was tested for backwards compatibility, making sure we can parse events indexed with older versions of Tendermint (without this fix).
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments