8000 refactor(p2p/netaddress)!: move to netaddr by melekes · Pull Request #4303 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(p2p/netaddress)!: move to netaddr #4303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 24, 2024
Merged

Conversation

melekes
Copy link
Contributor
@melekes melekes commented Oct 18, 2024

Refs #4302

Important: no logic has been changed; just moving stuff and updating interfaces.

Public API Changes

  • Package Renaming: The netaddress package is renamed to netaddr.
  • Removal of Prefix: The NetAddress prefix has been removed from relevant types and methods for better alignment with Go naming conventions.

@melekes melekes requested a review from a team as a code owner October 18, 2024 05:08
@melekes melekes requested a review from a team October 18, 2024 05:08
@melekes melekes self-assigned this Oct 18, 2024
@melekes melekes added p2p hygiene Any work relating to code legibility/hygiene to make it easier to read breaking A breaking change labels Oct 18, 2024
Copy link
Contributor
@andynog andynog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I've made a few comments and suggestions. Also, not sure if a change log entry is needed at this stage.

Base automatically changed from 2128-quic-go to main October 24, 2024 05:34
@melekes melekes requested a review from a team as a code owner October 24, 2024 05:34
@melekes melekes force-pushed the 2128-quic-go-netaddress branch from ddda651 to 48f1cb4 Compare October 24, 2024 05:38
@melekes melekes added this pull request to the merge queue Oct 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 24, 2024
@melekes melekes added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit 3bd747e Oct 24, 2024
37 checks passed
@melekes melekes deleted the 2128-quic-go-netaddress branch October 24, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A breaking change hygiene Any work relating to code legibility/hygiene to make it easier to read p2p
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0