8000 Move `mempoolIDs` back to `mempool/ids.go` by hvanz · Pull Request #467 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Move mempoolIDs back to mempool/ids.go #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 8, 2023
Merged

Move mempoolIDs back to mempool/ids.go #467

merged 2 commits into from
Mar 8, 2023

Conversation

hvanz
Copy link
Member
@hvanz hvanz commented Mar 6, 2023 •
edited
Loading

With the introduction of the priority mempool, mempoolIDs was moved from the file mempool/ids.go to mempool/v0/reactor.go and mempool/v1/reactor.go, while leaving mempool/ids.go empty.

This PR moves the code back to mempool/ids.go and complements #260.

PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

@hvanz hvanz changed the title Move mempoolIDs back from reactor.go to ids.go Move mempoolIDs back to mempool/ids.go Mar 6, 2023
@hvanz hvanz self-assigned this Mar 6, 2023
@hvanz hvanz added the mempool label Mar 6, 2023
@hvanz hvanz marked this pull request as ready for review March 7, 2023 08:31
@hvanz hvanz requested a review from a team as a code owner March 7, 2023 08:31
@hvanz hvanz merged commit 24040f5 into main Mar 8, 2023
@hvanz hvanz deleted the hernan/refactor-mempool-ids branch March 8, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lasarojc lasarojc lasarojc approved these changes

Assignees

@hvanz hvanz

Labels
mempool
Projects
No open projects
CometBFT 2023
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hvanz @lasarojc
0