Compare types.proto and feature/abci++vef and tip of v0.36.x
#488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
types.proto in feature/abci++vef and tip of v0.36.xtypes.proto and feature/abci++vef and tip of v0.36.x
jmalicevic
reviewed
Mar 10, 2023
| // agreed_app_data is the bytes that all nodes reach consensus upon in the following height. It is often the hash of the applications' state which can be used to confirm that execution of the transactions was deterministic. | ||
| bytes agreed_app_data = 5; | ||
| // app_hash is the hash of the applications' state which is used to confirm that execution of the transactions was deterministic. It is up to the application to decide which algorithm to use. | ||
| bytes app_hash = 5; |
There was a problem hiding this comment.
As we renamed this parameter, should it keep the same sequence number of should we give it a 6?
There was a problem hiding this comment.
The parameter is new in this branch (doesn't exist out of it)
lasarojc
approved these changes
Mar 10, 2023
sergio-mena
added a commit
that referenced
this pull request
Mar 14, 2023
* Move `apphash`from `Commit`to `FinalizeBlock` (leftovers) (#478) * [partial cherry-pick] abci: Move `app_hash` parameter from `Commit` to `FinalizeBlock` (#8664) * Removed from proto * make proto-gen * make build works * make some tests pass * Fix TestMempoolTxConcurrentWithCommit * Minor change * Update abci/types/types.go * Update internal/state/execution.go * Update test/e2e/app/state.go Co-authored-by: Callum Waters <cmwaters19@gmail.com> * Updated changelog and `UPGRADING.md` * Fixed abci-cli tests, and doc * Addressed @cmwaters' comments * Addressed @cmwaters' comments, part 2 Co-authored-by: Callum Waters <cmwaters19@gmail.com> * Levftover typo in spec --------- Co-authored-by: Callum Waters <cmwaters19@gmail.com> * Compare `types.proto` and `feature/abci++vef` and tip of `v0.36.x` (#488) * CometBFT renaming in types.proto * AppHash * Make proto-gen * Trying 1.20.2 explicitly * Votes can't have zero height (#511) * [partial cherry-pick] e2e: programmable ABCI method times (#8638) (#515) * e2e: programmable ABCI method times * fix linting error Co-authored-by: Callum Waters <cmwaters19@gmail.com> * Pass signatures of vote extensions in `RequestPrepareProposal` (#489) * Pass vote extension signature in `PrepareProposal` * make proto-gen * Verify extensions at PrepareProposal * Addressed @thanethomson's comments * Fix vote extension activation in e2e * ProcessProposal: 1st try * Working.... * Refactoring * Verify signatrue in unit test * spacing * Addressed @lasarojc's comments * Fix test --------- Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #10
Only minor renaming needed
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments