8000 ci: remove govulncheck by melekes · Pull Request #4946 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ci: remove govulncheck #4946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2025
Merged

ci: remove govulncheck #4946

merged 1 commit into from
Feb 10, 2025

Conversation

melekes
Copy link
Contributor
@melekes melekes commented Feb 10, 2025

Closes #4945

@melekes melekes requested review from a team as code owners February 10, 2025 06:16
@melekes melekes self-assigned this Feb 10, 2025
@melekes melekes added the ci Continuous integration-related label Feb 10, 2025
@melekes
Copy link
Contributor Author
melekes commented Feb 10, 2025 •
edited
Loading

govulncheck must be removed from the required jobs list by the repo admin.

@melekes
Copy link
Contributor Author
melekes commented Feb 10, 2025

govulncheck must be removed from the required jobs list by the repo admin.

cc @zrbecker

@melekes melekes enabled auto-merge February 10, 2025 06:38
@melekes melekes added this pull request to the merge queue Feb 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 10, 2025
@melekes melekes added this pull request to the merge queue Feb 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 10, 2025
@melekes melekes added this pull request to the merge queue Feb 10, 2025
Merged via the queue into main with commit c3ac62d Feb 10, 2025
33 checks passed
@melekes melekes deleted the 4945-remove-govulncheck branch February 10, 2025 06:57
@melekes melekes mentioned this pull request Feb 10, 2025
Merged
@Zygimantass
Copy link

was it possible to exclude the MSRV check and keep all of the other ones?

@zrbecker zrbecker added backport-to-v0.38.x Tell Mergify to backport the PR to v0.38.x backport-to-v1.x Tell Mergify to backport the PR to v1.x labels Feb 18, 2025
mergify bot pushed a comm 8000 it that referenced this pull request Feb 18, 2025
@melekes @mergify
ci: remove govulncheck (#4946)
65f94be 
Closes #4945

(cherry picked from commit c3ac62d)

# Conflicts:
#	.github/workflows/govulncheck.yml
@mergify mergify bot mentioned this pull request Feb 18, 2025
Merged
mergify bot pushed a commit that referenced this pull request Feb 18, 2025
@melekes @mergify
ci: remove govulncheck (#4946)
a3e15d8 
Closes #4945

(cherry picked from commit c3ac62d)

# Conflicts:
#	.github/workflows/govulncheck.yml
#	Makefile
@mergify mergify bot mentioned this pull request Feb 18, 2025
Merged
mergify bot added a commit that referenced this pull request Feb 18, 2025
@mergify @melekes @zrbecker
ci: remove govulncheck (backport #4946) (#4960)
5bcb750 
Closes #4945
<hr>This is an automatic backport of pull request #4946 done by
[Mergify](https://mergify.com).

---------

Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Co-authored-by: Zachary Becker <zachary@interchainlabs.io>
zrbecker added a commit that referenced this pull request Feb 18, 2025
@mergify @melekes @zrbecker
ci: remove govulncheck (backport #4946) (#4961)
8c1d050 
Closes #4945
<hr>This is an automatic backport of pull request #4946 done by
[Mergify](https://mergify.com).

---------

Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Co-authored-by: Zachary Becker <zachary@interchainlabs.io>
@melekes
Copy link
Contributor Author
melekes commented Apr 17, 2025

was it possible to exclude the MSRV check and keep all of the other ones?

nope.

melekes added a commit to informalsystems/cometbft that referenced this pull request Apr 17, 2025
@melekes
ci: remove govulncheck
4e1ef46 
See cometbft#4946
@melekes melekes mentioned this pull request Apr 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zrbecker zrbecker zrbecker approved these changes

Assignees

@melekes melekes

Labels
backport-to-v0.38.x Tell Mergify to backport the PR to v0.38.x backport-to-v1.x Tell Mergify to backport the PR to v1.x ci Continuous integration-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proposal: remove govulncheck CI job
3 participants
@melekes @Zygimantass @zrbecker
0