8000 feat(privval): extend privval.Message interface to support signing arbitrary hashes by crStiv · Pull Request #5127 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(privval): extend privval.Message interface to support signing arbitrary hashes #5127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

feat(privval): extend privval.Message interface to support signing arbitrary hashes #5127

wants to merge 11 commits into from

Conversation

crStiv
Copy link
Contributor
@crStiv crStiv commented May 16, 2025

The proposed extension was added to support signing arbitrary p2p message hashes as described in issue #5126.

It adds:

  • New SignP2PMessageRequest and SignedP2PMessageResponse message types
  • Integration with existing privval requestHandler
  • New SignP2PMessage method for SignerClient
  • Test case to verify functionality

PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

@crStiv crStiv requested review from a team as code owners May 16, 2025 22:57
@ironbird-prod Ironbird (prod)
Copy link
ironbird-prod bot commented May 16, 2025
Ironbird - launch a network To use Ironbird, you can use the following commands:
  • /ironbird start OR /ironbird start --load-test-config= - Launch a testnet with the specified chain and load test configuration.
  • /ironbird chains - List of chain images that ironbird can use to spin-up testnet
  • /ironbird loadtests - List of load test modes that ironbird can run against testnet
Custom Load Test Configuration You can provide a custom load test configuration using the `--load-test-config=` flag: 
/ironbird start cosmos --load-test-config={
  "block_gas_limit_target": 0.75,
  "num_of_blocks": 50,
  "msgs": [
    {"weight": 0.3, "type": "MsgSend"},
    {"weight": 0.3, "type": "MsgMultiSend"},
	{"weight": 0.4, "type": "MsgArr", "ContainedType": "MsgSend", "NumMsgs": 3300}
  ]
}

Use /ironbird loadtests to see more examples.

rach-id
rach-id reviewed May 19, 2025
View reviewed changes
Copy link
@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a version implemented here: https://github.com/rach-id/cometbft/tree/rachid/support-digest-signing that we will port here once the issue is agreed upon.

no need to re-implement.

@crStiv crStiv closed this May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rach-id rach-id rach-id left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crStiv @rach-id
0