Fixed two bugs related to metrics #562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 20, 2023
adizere
approved these changes
Mar 21, 2023
jmalicevic
reviewed
Mar 21, 2023
| @@ -11,6 +11,7 @@ process_proposal_delay = "100ms" | |||
| check_tx_delay = "0ms" | |||
| # The most common case (e.g. Cosmos SDK-based chains). | |||
| abci_protocol = "builtin" | |||
| prometheus = true | |||
There was a problem hiding this comment.
So we are running prometheus enabled nodes in our CI as well? Is that going to cause too much noise?
There was a problem hiding this comment.
Prometheus is enabled from now on, but no server set up. Although it might seem a bit silly, it would have caught the two panics I saw when I started the DO testnet.
jmalicevic
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #10
When testing in prometheus-enabled testnets, we caught two places where the metrics gathering were causing a panic.
This PR also includes adjustments to e2e
ci.tomlconfig that is able to trigger these bugs.Finally (not important, but for the record), I have included the time window I used to extract metrics from the 200-node test.
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments