8000 Fix race condition in consensus.State code (backport #673) by mergify[bot] · Pull Request #690 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix race condition in consensus.State code (backport #673) #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2023
Merged

Fix race condition in consensus.State code (backport #673) #690

merged 1 commit into from
Apr 11, 2023

Conversation

mergify[bot]
Copy link
Contributor
@mergify mergify bot commented Apr 11, 2023

This is an automatic backport of pull request #673 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@sergio-mena @mergify
Fix race condition in consensus.State code (#673)
e8af09d 
* Repro in e2e tests

* Change something in the code

* Fix race condition in `SwitchToConsensus`

* Revert "Repro in e2e tests"

This reverts commit 4f441f8.

* RAII lock

(cherry picked from commit 6a96eca)
@mergify mergify bot requested a review from a team as a code owner April 11, 2023 10:08
@sergio-mena sergio-mena self-assigned this Apr 11, 2023
@sergio-mena sergio-mena added the bug Something isn't working label Apr 11, 2023
@sergio-mena sergio-mena merged commit e0b2aae into v0.37.x Apr 11, 2023
@sergio-mena sergio-mena deleted the mergify/bp/v0.37.x/pr-673 branch April 11, 2023 10:33
mark-rushakoff added a commit to cosmos/cosmos-sdk that referenced this pull request Apr 11, 2023
@mark-rushakoff
build(deps): use latest commit of CometBFT v0.37.x branch
9229042 
This includes two fixes for two data races that occasionally happen in
Cosmos SDK tests: cometbft/cometbft#690 and
cometbft/cometbft#532.

We will eventually be switching to CometBFT v0.38 (see #15519), which
also contains those fixes.
@mark-rushakoff mark-rushakoff mentioned this pull request Apr 11, 2023
Merged
8 tasks
roy-dydx pushed a commit to dydxprotocol/cometbft that referenced this pull request Jul 11, 2023
@mergify @sergio-mena @roy-dydx
Fix race condition in consensus.State code (cometbft#673) (cometbft#690)
8cc65fb 
* Repro in e2e tests

* Change something in the code

* Fix race condition in `SwitchToConsensus`

* Revert "Repro in e2e tests"

This reverts commit 4f441f8.

* RAII lock

(cherry picked from commit 6a96eca)

Co-authored-by: Sergio Mena <sergio@informal.systems>
@faddat faddat mentioned this pull request Jan 5, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergio-mena sergio-mena sergio-mena approved these changes

Assignees

@sergio-mena sergio-mena

Labels
bug Something isn't working
Projects
No open projects
CometBFT 2023
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sergio-mena
0