8000 Unsafe int cast in `kill` command by sergio-mena · Pull Request #783 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Unsafe int cast in kill command #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 4, 2023
Merged

Unsafe int cast in kill command #783

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bbd649b
Unsafe int cast in `kill` command
sergio-mena May 2, 2023
066b9e2
Revert "Unsafe int cast in `kill` command"
sergio-mena May 3, 2023
c57b9ba
Changed strategy
sergio-mena May 3, 2023
fa5d7f8
Merge branch 'main' into sergio/kill-cmd-bad-cast
sergio-mena May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cmd/cometbft/commands/debug/kill.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ $ cometbft debug 34255 /path/to/cmt-debug.zip`,
}

func killCmdHandler(_ *cobra.Command, args []string) error {
pid, err := strconv.ParseUint(args[0], 10, 64)
pid, err := strconv.Atoi(args[0])
if err != nil {
return err
}
Expand Down Expand Up @@ -100,7 +100,7 @@ func killCmdHandler(_ *cobra.Command, args []string) error {
// is tailed and piped to a file under the directory dir. An error is returned
// if the output file cannot be created or the tail command cannot be started.
// An error is not returned if any subsequent syscall fails.
func killProc(pid uint64, dir string) error {
func killProc(pid int, dir string) error {
// pipe STDERR output from tailing the CometBFT process to a file
//
// NOTE: This will only work on UNIX systems.
Expand All @@ -123,7 +123,7 @@ func killProc(pid uint64, dir string) error {
go func() {
// Killing the CometBFT process with the '-ABRT|-6' signal will result in
// a goroutine stacktrace.
p, err := os.FindProcess(int(pid))
p, err := os.FindProcess(pid)
if err != nil {
fmt.Fprintf(os.Stderr, "failed to find PID to kill CometBFT process: %s", err)
} else if err = p.Signal(syscall.SIGABRT); err != nil {
Expand Down
0