-
Notifications
You must be signed in to change notification settings - Fork 650
feature/adr101: Sync with main
#847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thanethomson
merged 12 commits into
feature/adr101-pull-companion
from
thane/feature/adr101/merge-main
May 17, 2023
Merged
feature/adr101: Sync with main
#847
thanethomson
merged 12 commits into
feature/adr101-pull-companion
from
thane/feature/adr101/merge-main
May 17, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* spec/p2p: starting the specification of a Reactor * spec/p2p: generic service modelled in Quint * spec/p2p: minimal/initial reactor model in Quint * spec/p2p: P2P -> reactor interaction grammar * spec/p2p: routines modeled in reactor.qnt * spec/p2p: reactor.Receive) modeled in Quint * spec/p2p: reactor types moved to the beginning * spec/p2p: reactor Quint state encapsulated * spec/p2p: reactor with actions and defintions * spec/p2p: reactor SetSwitch() method modeled * spec/p2p: reactor Service interface modeled * spec/p2p: reactor setup action added * spec/p2p: reactor Quint spec cleanup * spec/p2p: reactor InitPeer spec updated * spec/p2p: reactor Quint simulation support * spec/p2p: reactor Quint spec refactored * spec/p2p: reactor grammar added to a rephrased README * spec/p2p: README structure reorganized * spec/p2p: reactor registration, overview * spec/p2p: reactor implements a service (start/stop) * spec/p2p: reactor peer management, overview * spec/p2p: reactor receive message method documented * spec/p2p: renamed to registration/register reactor * spec/p2p: reactor grammar refactoring, part I * spec/p2p: reactor grammar refactoring, part II * spec/p2p: reactor grammar refactoring, part III * spec/p2p: reactor grammar refactoring, part IV * spec/p2p: removing Quint model used as an example * spec/p2p: reactor grammar refactoring, part V * spec/p2p: reactor grammar refactoring, part VI * spec/p2p: reactor grammar refactoring, part VII * Apply suggestions from code review Co-authored-by: Josef Widder <44643235+josef-widder@users.noreply.github.com> * spec/p2p: reactor Quint model, some comments added * Update spec/p2p/reactor/reactor.qnt Co-authored-by: Lasaro <lasaro@informal.systems> * spec/p2p: syntax HL for Quint files Co-authored-by: Josef Widder <44643235+josef-widder@users.noreply.github.com> * spec/p2p: suggestions from code review Co-authored-by: Sergio Mena <sergio@informal.systems> * spec/p2p: reactor Quint model, channel ID as str * spec/p2p: applying suggestions from code review * spec/p2p: API methods first, then actions on Quint * spec/p2p: reactor Quint model, minor code cleanup * spec/p2p: reactor README intro slightly rephrased * spec/p2p: reactor grammar intro slightly rephrased * spec/p2p: some reactor "should" replaced by "must" * spec/p2p: Quint model reference on README updated * spec/p2p: minor fixes on reactor's README --------- Co-authored-by: Daniel Cason <cason@lausanne.local> Co-authored-by: Josef Widder <44643235+josef-widder@users.noreply.github.com> Co-authored-by: Lasaro <lasaro@informal.systems> Co-authored-by: Sergio Mena <sergio@informal.systems>
Bumps [github.com/docker/distribution](https://github.com/docker/distribution) from 2.8.1+incompatible to 2.8.2+incompatible. - [Release notes](https://github.com/docker/distribution/releases) - [Commits](distribution/distribution@v2.8.1...v2.8.2) --- updated-dependencies: - dependency-name: github.com/docker/distribution dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/cloudflare/circl](https://github.com/cloudflare/circl) from 1.3.1 to 1.3.3. - [Release notes](https://github.com/cloudflare/circl/releases) - [Commits](cloudflare/circl@v1.3.1...v1.3.3) --- updated-dependencies: - dependency-name: github.com/cloudflare/circl dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add first draft of ADR-103 * Add rollout strategy * Expand on problem with manual diffs * Clarify that code generators generate breaking code from non-breaking proto changes * Clarify that consolidation only applies to currently maintained versions --------- Signed-off-by: Thane Thomson <connect@thanethomson.com>
) Bumps [github.com/cosmos/gogoproto](https://github.com/cosmos/gogoproto) from 1.4.9 to 1.4.10. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/cosmos/gogoproto/releases">github.com/cosmos/gogoproto's releases</a>.</em></p> <blockquote> <h2>v1.4.10</h2> <h2>What's Changed</h2> <ul> <li>docs: v1.4.9 CHANGELOG by <a href="https://github.com/aaronc"><code>@aaronc</code></a> in <a href="https://redirect.github.com/cosmos/gogoproto/pull/63">cosmos/gogoproto#63</a></li> <li>chore(deps): bump bufbuild/buf-setup-action from 1.17.0 to 1.18.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/cosmos/gogoproto/pull/65">cosmos/gogoproto#65</a></li> <li>chore(deps): bump google.golang.org/grpc from 1.54.0 to 1.55.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/cosmos/gogoproto/pull/64">cosmos/gogoproto#64</a></li> <li>chore: remove double registration warning by <a href="https://github.com/julienrbrt"><code>@julienrbrt</code></a> in <a href="https://redirect.github.com/cosmos/gogoproto/pull/67">cosmos/gogoproto#67</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/cosmos/gogoproto/compare/v1.4.9...v1.4.10">https://github.com/cosmos/gogoproto/compare/v1.4.9...v1.4.10</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/cosmos/gogoproto/blob/main/CHANGELOG.md">github.com/cosmos/gogoproto's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/cosmos/gogoproto/releases/tag/v1.4.10">v1.4.10</a> - 2023-05-11</h2> <ul> <li><a href="https://redirect.github.com/cosmos/gogoproto/pull/67">#67</a> Remove warning about double registration. The Cosmos SDK does purposely double-registration so this warning is not useful.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/cosmos/gogoproto/commit/28c37ed426b256e2d84b3bb4e39160cb722b7124"><code>28c37ed</code></a> chore: remove double registration warning (<a href="https://redirect.github.com/cosmos/gogoproto/issues/67">#67</a>)</li> <li><a href="https://github.com/cosmos/gogoproto/commit/413865aa4f3ccb002cbd0a0629e1d773fd360c62"><code>413865a</code></a> chore(deps): bump google.golang.org/grpc from 1.54.0 to 1.55.0 (<a href="https://redirect.github.com/cosmos/gogoproto/issues/64">#64</a>)</li> <li><a href="https://github.com/cosmos/gogoproto/commit/d4ceb7578f27fecf966ee0c369d6e3390937bbfe"><code>d4ceb75</code></a> chore(deps): bump bufbuild/buf-setup-action from 1.17.0 to 1.18.0 (<a href="https://redirect.github.com/cosmos/gogoproto/issues/65">#65</a>)</li> <li><a href="https://github.com/cosmos/gogoproto/commit/e74325c28e5afd903904724e66228d4ed3457b7e"><code>e74325c</code></a> docs: v1.4.9 CHANGELOG (<a href="https://redirect.github.com/cosmos/gogoproto/issues/63">#63</a>)</li> <li>See full diff in <a href="https://github.com/cosmos/gogoproto/compare/v1.4.9...v1.4.10">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.9.0 to 0.10.0. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/golang/net/commit/daac0cec0cf964a628a29bb4b82940c225b921ed"><code>daac0ce</code></a> go.mod: update golang.org/x dependencies</li> <li><a href="https://github.com/golang/net/commit/82780d606d189ee6d3e9dd4683e493d832f3caaf"><code>82780d6</code></a> http2: don't reuse connections that are experiencing errors</li> <li><a href="https://github.com/golang/net/commit/0bfab66a03570232c7aaea77dcdd2355ae6e9db8"><code>0bfab66</code></a> ipv4, ipv6: drop redundant skip checks based on GOOS</li> <li><a href="https://github.com/golang/net/commit/938ff153cfff2268dc5ceb9f99755390cf4c9af4"><code>938ff15</code></a> ipv4, ipv6, nettest: skip unsupported tests on wasip1</li> <li><a href="https://github.com/golang/net/commit/eb1572ce7f7a6e97ec44c27568286345c2a7748e"><code>eb1572c</code></a> html: another shot at security doc</li> <li><a href="https://github.com/golang/net/commit/9001ca7de9d738aed247bf005debccb5b186a965"><code>9001ca7</code></a> nettest: re-enable unixpacket tests on netbsd/386</li> <li><a href="https://github.com/golang/net/commit/3d5a8ee7d3fea95fe897dc5983ec8a1afc5a04ab"><code>3d5a8ee</code></a> internal/socks: permit authenticating with an empty password</li> <li>See full diff in <a href="https://github.com/golang/net/compare/v0.9.0...v0.10.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.8.0 to 0.9.0. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/golang/crypto/commit/a4e984136a63c90def42a9336ac6507c2f6a896d"><code>a4e9841</code></a> go.mod: update golang.org/x dependencies</li> <li><a href="https://github.com/golang/crypto/commit/3ef80564904258d0d9b19a879c805574d184f941"><code>3ef8056</code></a> ssh/test: enable on solaris</li> <li><a href="https://github.com/golang/crypto/commit/a8cc953517d1e689f501d9fcd7b6659a177d2216"><code>a8cc953</code></a> ssh: skip unsupported tests on wasip1</li> <li><a href="https://github.com/golang/crypto/commit/7d6d3f5d4adbee52131e89d4465c8cdf88d80aad"><code>7d6d3f5</code></a> ssh/test: skip TestValidTerminalMode on non-Bourne shells</li> <li><a href="https://github.com/golang/crypto/commit/1faeef9713563c936e077b84e4c3a0f3cac0fbe4"><code>1faeef9</code></a> cryptobyte: reject Object Identifiers with leading 0x80</li> <li>See full diff in <a href="https://github.com/golang/crypto/compare/v0.8.0...v0.9.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
…833) Bumps [github.com/vektra/mockery/v2](https://github.com/vektra/mockery) from 2.26.1 to 2.27.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/vektra/mockery/releases">github.com/vektra/mockery/v2's releases</a>.</em></p> <blockquote> <h2>v2.27.1</h2> <h2>Changelog</h2> <ul> <li>57df870 Merge pull request <a href="https://redirect.github.com/vektra/mockery/issues/626">#626</a> from LandonTClipp/packages_beta</li> <li>6359747 Move <code>packages</code> to a beta state</li> <li>b1a302a Update features.md</li> <li>b3d99dd Update migrating_to_packages.md</li> </ul> <h2>v2.27.0</h2> <h2>Changelog</h2> <ul> <li>66f7b66 Add InterfaceDirRelative template variable</li> <li>fd7a1ab Add docs for <code>boilerplate-file</code></li> <li>18a0dba Add packages migration docs</li> <li>1c1eeea Merge pull request <a href="https://redirect.github.com/vektra/mockery/issues/615">#615</a> from neverbeenthisweeb/neverbeenthisweeb/613-remove-debug-msg</li> <li>587e962 Merge pull request <a href="https://redirect.github.com/vektra/mockery/issues/620">#620</a> from vektra/docs</li> <li>05d270e Merge pull request <a href="https://redirect.github.com/vektra/mockery/issues/622">#622</a> from LandonTClipp/migration</li> <li>f9586f1 Merge pull request <a href="https://redirect.github.com/vektra/mockery/issues/625">#625</a> from LandonTClipp/issue_623</li> <li>4c99dea Remove debug log</li> <li>0e520a4 fix extra pipe</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/vektra/mockery/commit/57df870523797b39c0c0a620a61c9792dd061c24"><code>57df870</code></a> Merge pull request <a href="https://redirect.github.com/vektra/mockery/issues/626">#626</a> from LandonTClipp/packages_beta</li> <li><a href="https://github.com/vektra/mockery/commit/6359747d02713fae031dabacd684a03f82b6c649"><code>6359747</code></a> Move <code>packages</code> to a beta state</li> <li><a href="https://github.com/vektra/mockery/commit/b3d99dd77dd25cf6a437bbff1eeeb2111555e9ff"><code>b3d99dd</code></a> Update migrating_to_packages.md</li> <li><a href="https://github.com/vektra/mockery/commit/b1a302a65e883996e27a9abe4feefe0d68a8a18c"><code>b1a302a</code></a> Update features.md</li> <li><a href="https://github.com/vektra/mockery/commit/f9586f101d956c1a8d22fed4ecfb7f9b3b1c4dd8"><code>f9586f1</code></a> Merge pull request <a href="https://redirect.github.com/vektra/mockery/issues/625">#625</a> from LandonTClipp/issue_623</li> <li><a href="https://github.com/vektra/mockery/commit/66f7b66ec23a4312bcf844bd3d76e88bbfd635ac"><code>66f7b66</code></a> Add InterfaceDirRelative template variable</li> <li><a href="https://github.com/vektra/mockery/commit/05d270ea0bee3af478f94bae99aecace801fdc45"><code>05d270e</code></a> Merge pull request <a href="https://redirect.github.com/vektra/mockery/issues/622">#622</a> from LandonTClipp/migration</li> <li><a href="https://github.com/vektra/mockery/commit/18a0dbaef75ff9035cfdfcaca07917d9e991386b"><code>18a0dba</code></a> Add packages migration docs</li> <li><a href="https://github.com/vektra/mockery/commit/587e9624e0528458e4b1febcbf2c26abbab79ae2"><code>587e962</code></a> Merge pull request <a href="https://redirect.github.com/vektra/mockery/issues/620">#620</a> from vektra/docs</li> <li><a href="https://github.com/vektra/mockery/commit/0e520a418667b3afc458370de582c31c56abc7ff"><code>0e520a4</code></a> fix extra pipe</li> <li>Additional commits viewable in <a href="https://github.com/vektra/mockery/compare/v2.26.1...v2.27.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
* rpc: Truncate response data in response failure logs Signed-off-by: Thane Thomson <connect@thanethomson.com> * rpc: Remove response logging for errors Signed-off-by: Thane Thomson <connect@thanethomson.com> --------- Signed-off-by: Thane Thomson <connect@thanethomson.com>
* Applied Michaels patch * Added corner case tests, failing curently * Support for big floats and ints added * Added new util file * Fixed linter error * added internal package * Revert "added internal package" This reverts commit ef7f2b4. * added internal/indexer * Moved utils to internal * Fixed linter * Updated docs * Applied @sergio-mena s PR comments * Fixed linter * Return with error in compare float * Changelog entries * Apply lasaroj's comments. Co-authored-by: Lasaro <lasaro@informal.systems> * applied some PR comments * updated docs Co-authored-by: Sergio Mena <sergio@informal.systems> * Added errors and logger * Fixed linter * Fixed sentence in comment * Removed changelog * Avoid converting to string when parsing int to float * Added unexpected types to error messages * Added comment on the 8atom regex in pubsub --------- Co-authored-by: Lasaro <lasaro@informal.systems> Co-authored-by: Sergio Mena <sergio@informal.systems>
#796) * shim in start and stop methods * rename to 'tendermint' * rename to 'kill tendermint' * add terminate vs kill * add command package * add param names * switch exec compose to docker pkg * all exec switched to docker package * remove runner exec * functionality in place for start kill terminate * exec compose takes context * compose verbose takes context * docker.exec takes context * add create node to infra provider * start and create calls replaced with infra provider * commit exec pkg * add ssh pkg * add digital ocean package * add client creation logic * use ssh agent to auth to remote * plump infra data into tests * move agent socket dial to client connection creation * error if auth sock not defined * allow unknown hosts to be accessed * return session error * close connection in ssh exec * gofmt * use IP.Equal instead of bytes.Equal * correct the nolint comment format * remove backup for INFRASTRUCTURE_DATA missing * Update test/e2e/pkg/infra/digitalocean/digitalocean.go Co-authored-by: Thane Thomson <connect@thanethomson.com> * remove hostkeyalgorithm setting * rename IP node field * add external address field * use external IP in digital ocean * use correct variable in e2e compose * use --no-start * Fix reachable IPs on docker * Rename to CometBFT * Simplify Path * Revert GetReachableIP * Improve ext IP * Remove CreateNode * Adapt provider interface to actual needs * Minor in digitalocean * Doc * Fix contexts * Update test/e2e/pkg/infra/digitalocean/digitalocean.go * Update test/e2e/pkg/exec/exec.go Co-authored-by: Lasaro <lasaro@informal.systems> * Remove `cli.ifd`, first version * Remove `cli.ifd`, reduce duplication * Remove references to Docker in help strings --------- Co-authored-by: William Banfield <wbanfield@gmail.com> Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com> Co-authored-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Lasaro <lasaro@informal.systems>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
sergio-mena
approved these changes
May 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good! :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
feature/adr101-pull-companion
branch with the latest changes frommain
.@sergio-mena let me know if there's a different approach you'd recommend here to the merge than the one I've taken. There were some conflicts between my E2E work and your work in #796 in:
PR checklist
.changelog
(we use unclog to manage our changelog)docs/
orspec/
) and code comments