8000 Release v0.37.2 by thanethomson · Pull Request #972 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Release v0.37.2 #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 14, 2023
Merged

Release v0.37.2 #972

merged 7 commits into from
Jun 14, 2023

Conversation

thanethomson
Copy link
Contributor

📖 CHANGELOG rendered


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson added the release Pull requests that facilitate cutting a release label Jun 14, 2023
@thanethomson thanethomson requested a review from a team as a code owner June 14, 2023 19:05
Golang recently started offering Debian Bookworm as the default distro
for `golang:1.20`, which provides a newer version of RocksDB than what
we support in cometbft-db.

For now this pins the image to Bullseye, which is the base image we have
been using for some time now.

Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson
Copy link
Contributor Author

Please take note of 336c3c0: sometime in the past day, the default base OS for golang:1.20 was upgraded from Debian Bullseye (the one we've been using for quite some time now for our E2E image) to Bookworm, which includes a newer version of RocksDB than cometbft-db currently supports.

This pins our E2E image to Bullseye for now until we resolve cometbft/cometbft-db#58, after which we'll be able to use Bookworm with a newer version of RocksDB.

Copy link
Contributor
@sergio-mena sergio-mena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!

@thanethomson thanethomson merged commit fe45483 into v0.37.x Jun 14, 2023
@thanethomson thanethomson deleted the release/v0.37.2 branch June 14, 2023 20:12
@mzabaluev
Copy link
Contributor

This pins our E2E image to Bullseye for now until we resolve cometbft/cometbft-db#58, after which we'll be able to use Bookworm with a newer version of RocksDB.

Should this be cherry-picked into main and other branches?

DongLieu pushed a commit to DongCoNY/cometbft that referenced this pull request May 13, 2024
* changelog: Clean up and reorder

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* changelog: Add severity to security fixes

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* changelog: Add missing entries

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* changelog: Release v0.37.2

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Rebuild changelog

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* version: Bump to v0.37.2

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* test/e2e: Use Debian Bullseye as base image

Golang recently started offering Debian Bookworm as the default distro
for `golang:1.20`, which provides a newer version of RocksDB than what
we support in cometbft-db.

For now this pins the image to Bullseye, which is the base image we have
been using for some time now.

Signed-off-by: Thane Thomson <connect@thanethomson.com>

---------

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Pull requests that facilitate cutting a release
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants
0