-
Notifications
You must be signed in to change notification settings - Fork 67
Release v0.7.0 #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.7.0 #29
Conversation
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@@ -0,0 +1,2 @@ | |||
- Fork tm-db and rename fork to cometbft-db | |||
([#7](https://github.com/cometbft/cometbft-db/issues/7)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Escape the number.
Optionally, use the PR instead of the issue number.
([#7](https://github.com/cometbft/cometbft-db/issues/7)) | |
([\#29](https://github.com/cometbft/cometbft-db/pull/29)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The historical convention has always been to refer to issues. The only reason why most changelog issues have included references to PRs is because contributors haven't been very good at capturing the problems they're trying to solve in issues 🙂
For now the escaping doesn't affect the rendering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer issues as well, since they may refer to multiple PR that sum to fix it, but I was going by the contributing guide that states "It's also acceptable for xxx to refer to the relevant issue number, but pull-request numbers are preferred. " We need to update it then.
Signed-off-by: Thane Thomson <connect@thanethomson.com>
📖 CHANGELOG rendered