8000 Update `filter_files_content_types` to support filtering 3d models by christian-byrne · Pull Request #7572 · comfyanonymous/ComfyUI · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

8000 Update filter_files_content_types to support filtering 3d models #7572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 12, 2025
Merged

Update filter_files_content_types to support filtering 3d models #7572

merged 5 commits into from
Apr 12, 2025

Conversation

christian-byrne
Copy link
Collaborator
@christian-byrne christian-byrne commented Apr 11, 2025 •
edited
Loading

Updates type, docstring, and unit tests for filter_files_content_types function of folder_paths module to support filtering 3d model files, as ComfyUI now supports 3D.

fbx is added to the mimetype cache manually, as .fbx (Filmbox) files aren't included in the standard MIME type databases on many systems, including Ubuntu. (FBX is a proprietary 3D model format developed by Autodesk.)

@comfyanonymous comfyanonymous merged commit c87a06f into comfyanonymous:master Apr 12, 2025
5 checks passed
@christian-byrne christian-byrne deleted the add-3dmodel-to-filter branch April 13, 2025 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtydhr88 jtydhr88 jtydhr88 left review comments

@yoland68 yoland68 Awaiting requested review from yoland68 yoland68 is a code owner

@robinjhuang robinjhuang Awaiting requested review from robinjhuang robinjhuang is a code owner

@huchenlei huchenlei Awaiting requested review from huchenlei huchenlei is a code owner

@webfiltered webfiltered Awaiting requested review from webfiltered webfiltered is a code owner

@pythongosssss pythongosssss Awaiting requested review from pythongosssss pythongosssss is a code owner

@ltdrdata ltdrdata Awaiting requested review from ltdrdata ltdrdata is a code owner

@Kosinkadi 64DF nk Kosinkadink Awaiting requested review from Kosinkadink Kosinkadink is a code owner

@comfyanonymous comfyanonymous Awaiting requested review from comfyanonymous comfyanonymous is a code owner

Assignees
No one assigned
Labels
Important
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christian-byrne @jtydhr88 @huchenlei @comfyanonymous
0