Hidream: Allow loading hidream text encoders in CLIPLoader and DualCLIPLoader #7676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate of #7632 ? |
|
Can you fix the ruff style check? |
No problem. Apologize to forget to do ruff check. |
|
Fine. I've fixed the problems in the code, waiting for your check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue: #7665
Asked some community users. They would like this optimization.
Now, using dual clip may cause black output when passing KSampler in DualCLIPLoader.
Here's some workflows that can test this PR.
CLIPLoader with Llama-3.1:
DualCLIPLoader with both T5 and Llama-3.1:
These both workflows tested successfully on Ubuntu with RTX 4090.