Make line highlight more visible in dark mode. #3846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I personally think it's best with your change, thanks! Will wait a bit for others to chime in :) Thanks! |
dkm
approved these changes
Jul 6, 2022
junlarsen
approved these changes
Jul 6, 2022
8000
|
Probably should not let a colourblind person choose the colours next time 😁 d005bf3#diff-16cd9f6348f97eeb5a1bf243ab2c22069e878322ada4932777da9e71dc210f05 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to change the line highlight for dark mode, from:
to:
The former is barely visible if the screen is not well calibrated, which happens a lot during conference presentations for example.