8000 List refactor (CTotalOrder) by mweidner037 · Pull Request #265 · composablesys/collabs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

List refactor (CTotalOrder) #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in t 8000 o your account

Jump to bottom
Merged
merged 12 commits into from
Jul 31, 2023
Merged

List refactor (CTotalOrder) #265

merged 12 commits into from
Jul 31, 2023

Conversation

mweidner037
Copy link
Collaborator

Completes #264

  • Rename CPositionSource to CTotalOrder, and clarify its abstraction in the docs: an abstract total order on Positions without any actual values or presence.
  • Refactor CTotalOrder so that it only tracks waypoints, not which positions have actually been used. Instead, LocalList tracks that.
    • This simplifies CValueList's merge function.
    • To make this possible, CTotalOrder.createPositions now takes previous & next positions, not just a previous position, and creates new positions anywhere in between.
    • It should now be possible to share a CTotalOrder among multiple list CRDTs.
  • Other simplifications: directly expose totalOrder instead of newLocalList method; no CTotalOrder events.

@mweidner037 mweidner037 linked an issue Jul 31, 2023 that may be closed by this pull request
CPositionSource sharing #264
Closed
5 tasks
@mweidner037 mweidner037 merged commit c5c3dcd into develop Jul 31, 2023
@mweidner037 mweidner037 deleted the position-sharing branch July 31, 2023 22:54
@mweidner037 mweidner037 mentioned this pull request Aug 14, 2023
Merged
mweidner037 added a commit that referenced this pull request Aug 14, 2023
@mweidner037
List refactor (CTotalOrder) (#265)
dd8b5ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CPositionSource sharing
1 participant
@mweidner037
0