IPv6 addresses can be in brackets for services.ports #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifies that IPv6 addresses in the ports short syntax can be enclosed in square brackets. This is already mentioned for the extra_hosts attribute, but not for ports. The reference library (compose-go) already supports IPv6 addresses with or without square brackets. This commit documents that fact and adds a couple of examples. Signed-off-by: Paul Nettleton <k9@k9withabone.dev>
ndeloof
approved these changes
Jan 9, 2025
|
please run |
aevesdocker
added a commit
to docker/docs
that referenced
this pull request
Jan 13, 2025
<!--Delete sections as needed --> ## Description Updates Compose Spec with content in compose-spec/compose-spec#530 Also some freshness of the `ports` attribute ## Related issues or tickets <!-- Related issues, pull requests, or Jira tickets --> ## Reviews <!-- Notes for reviewers here --> <!-- List applicable reviews (optionally @tag reviewers) --> - [ ] Technical review - [ ] Editorial review - [ ] Product review
|
ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Specifies that IPv6 addresses in the
portsshort syntax can be enclosed in square brackets. This is already mentioned for theextra_hostsattribute, but not for ports. The reference library (compose-go) already supports IPv6 addresses with or without square brackets. This commit documents that fact and adds a couple of examples.Which issue(s) this PR fixes:
N/A, minor documentation change/clarification.