8000 introduce models by ndeloof · Pull Request #604 · compose-spec/compose-spec · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

introduce models #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHu 8000 b? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

introduce models #604

merged 1 commit into from
Jun 30, 2025
+168 −1

Conversation

ndeloof
Copy link
Collaborator
@ndeloof ndeloof commented Jun 26, 2025 •
edited
Loading

documentation for compose-spec/compose-go#799

cc @xenoscopic as I'm not confident enough with this topic to offer relevant descriptions :)

@ndeloof ndeloof force-pushed the models branch 3 times, most recently from 1bd69a7 to db2b79a Compare June 26, 2025 06:38
rcjsuen
rcjsuen reviewed Jun 26, 2025
View reviewed changes
xenoscopic
xenoscopic reviewed Jun 26, 2025
View reviewed changes
xenoscopic
xenoscopic reviewed Jun 26, 2025
View reviewed changes
@ndeloof ndeloof force-pushed the models branch 2 times, most recently from 98d4cea to a5aaeda Compare June 27, 2025 06:16
glours
glours reviewed Jun 27, 2025
View reviewed changes
Copy link
Contributor
@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 question and a nit to fix 😉

@ndeloof ndeloof force-pushed the models branch 2 times, most recently from 254352f to 6117f9a Compare June 27, 2025 15:05
mikesir87
mikesir87 reviewed Jun 27, 2025
View reviewed changes
Copy link
Contributor
@mikesir87 mikesir87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a couple of small typo nits

@ndeloof ndeloof force-pushed the models branch 3 times, most recently from 2638945 to a0f1312 Compare June 30, 2025 15:38
@ndeloof ndeloof enabled auto-merge (rebase) June 30, 2025 15:38
@ndeloof
introduce models
d2d6b0a 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
glours
glours approved these changes Jun 30, 2025
View reviewed changes
Copy link
Contributor
@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof ndeloof merged commit 00655e2 into compose-spec:main Jun 30, 2025
2 of 3 checks passed
@ndeloof ndeloof deleted the models branch June 30, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikesir87 mikesir87 mikesir87 left review comments

@xenoscopic xenoscopic xenoscopic left review comments

@rcjsuen rcjsuen rcjsuen left review comments

@glours glours glours approved these changes

@doringeman doringeman doringeman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ndeloof @glours @mikesir87 @xenoscopic @rcjsuen @doringeman
0