Make the require command guess versions more accurately #11160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to the solver (except with --no-update)
mnocon
added a commit
to mnocon/composer-checkout
that referenced
this pull request
Dec 1, 2022
nicolas-grekas
added a commit
to symfony/orm-pack
that referenced
this pull request
Dec 5, 2022
This works around #37 Note that after composer/composer#11160, Composer 2.5 would be able to take the conflict into account and thus not fall into #37, but we're not yet there.
nicolas-grekas
added a commit
to symfony/orm-pack
that referenced
this pull request
Dec 5, 2022
This works around #37 Note that after composer/composer#11160, Composer 2.5 would be able to take the conflict into account and thus not fall into #37, but we're not yet there.
emahorvat52
pushed a commit
to emahorvat52/composer
that referenced
this pull request
Feb 3, 2023
… to the solver (except with --no-update) (composer#11160)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no version is provided we usually select the latest working version but in some cases this leads to problems if that conflicts with other stuff you have installed.
This PR makes it instead use a
*constraint temporarily, effectively delegating the job to the solver (except if called with --no-update then we still use the best-effort version selector stuff). Once we have a solution we then replace version constraints again with whatever the locked version is.This should improve the
requireexperience especially for people that do not have very up to date dependencies.