Allow custom scripts to be defined directly by its Command's props/methods
#12403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…methods Builds on top of composer#11151; originally mentioned at composer#11134 - composer#11134 (comment)
…ptions from any Symfony Command00
I also added some commas, mostly suggested by PHPStorm - I do think they make sense, though. Lastly, I changed a sentence that had some unneeded text repetition.
Changing the `RunScriptCommand`'s `instanceof` to `Command` was redundant, so I removed it. Still not sure why it was there in the first place, so this might be a bad removal.
|
PHPStan is failing for a file I didn't edit, so I'm not fixing it with fear of conflicts 😅 |
|
You can rebase if you want to fix the build. I'll need some more time to review the rest sorry. |
|
No sorries. This is open source software! Take your time, sir haha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long story short, this allows
Commandsubclasses to have complete definitions inside them, instead of splitting the command and description betweencomposer.jsonand the class contents.I included this because, otherwise, someone may try to use
setName()orsetDescription()and get confused - whilesetHelp()can still only be defined inside the class.It's also useful when defining a family of script classes, for writing dynamic descriptions, or pairing the description with the long help contents.
I'm just not sure about the change in
Command\RunScriptCommand- was there a specific reason for it to filter only forScriptAliasCommand, or could it be simply because there were no other subclasses ofCommandat that time?Also: I guess we should now rename
$dummyatConsole\Application? In fact, when thenameis defined inside the Command, the dummy value ends up being the array key 😂