8000 feat: Added --ignore-unreachable flag to audit command for private/unreachable repositories by sschueller · Pull Request #12470 · composer/composer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Added --ignore-unreachable flag to audit command for private/unreachable repositories #12470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sschueller
Copy link

As discussed in #12467 this adds the option --ignore-unreachable which will let the audit command run even if repositories are unreachable. They will be listed as unreachable in the report.

No change has been made to the overall error handling.

@sschueller
Copy link
Author

I'm not sure why phpstan failed, it ran fine on my side: https://github.com/i-web/composer/actions/runs/16144638585/job/45560116487

@stof
Copy link
Contributor
stof commented Jul 8, 2025

This implementation is ignoring all repositories when one of them is unreachable instead of ignoring only the unreachable one.
The try/catch needs to be done inside the RepositorySet to handle each repository separately.

@sschueller
Copy link
Author
sschueller commented Jul 9, 2025

@stof Thank you for catching this. I have corrected it and tested it with several of my repos now (not only the ones where the protected package is the last in the list...)

@Seldaek Seldaek added this to the 2.9 milestone Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0