Fix type of $learnedLiterals to avoid issues #12121
Merged
+179
−575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
composer.lockPackage changes
Dev Package changes
Settings · Docs · Powered by Private Packagist |
naderman
approved these changes
Sep 19, 2024
stof
reviewed
Sep 19, 2024
|
The composer.lock diff comment has been updated to reflect new changes in this PR. |
|
Ok some scope creep later.. I reviewed and fixed all but 5 phpstan errors in the entire DependencyResolver namespace :) |
stof
approved these changes
Sep 20, 2024
naderman
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's probably the 3rd time I look at that code because of some PHPStan error caused by this weird array with
[null|int, ...int]which cannot be expressed as a type.. So I finally decided to fix it. I'm not sure if you have a better name than $mainLiteral @naderman ?