8000 Detect missing packages that are a requirement or dev-requirement but not locked by PrinsFrank · Pull Request #9899 · composer/composer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Detect missing packages that are a requirement or dev-requirement but not locked #9899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 1, 2021
Merged

Detect missing packages that are a requirement or dev-requirement but not locked #9899

merged 3 commits into from
Jun 1, 2021

Conversation

PrinsFrank
Copy link
Contributor

Implements #9842

I tried writing contained code that works in 5.3. I'm not sure if this should live in it's own class and if there is a way to UT this, please let me know if you want anything changed!

@Seldaek Seldaek added this to the 2.1 milestone May 21, 2021
@mvorisek
Copy link
Contributor
mvorisek commented Jun 1, 2021

Hmm, what about merging composer.json rules with composer.lock and testing if that rules resolves to the same composer.lock?

a) It is quick
b) any difference is either an error in the lock file or composer.json represent unresolveable contraints (when merged with lock file) or was extended (and that dependencies are missing in the lock file)

Seldaek added a commit that referenced this pull request Jun 1, 2021
@Seldaek
Fix a few issues in lock file validation
2eaf81c 
- handle packages present but in wrong version
- handle provide/replace correctly
- do not validate if lock file is missing

refs #9899
@Seldaek Seldaek merged commit 69dc607 into composer:master Jun 1, 2021
@Seldaek
Copy link
Member
Seldaek commented Jun 1, 2021

Thanks @PrinsFrank - the implementation wasn't bad IMO but it missed a few corner cases and I had to implement it quite differently to fix them, see 2eaf81c if you're interested :)

@Seldaek
Copy link
Member
Seldaek commented Jun 1, 2021

@mvorisek check my commit, running the solver isn't necessary here.

@PrinsFrank PrinsFrank deleted the detect-missing-packages-on-validate branch June 3, 2021 13:34
@PrinsFrank PrinsFrank mentioned this pull request Oct 26, 2022
Merged
@PrinsFrank PrinsFrank mentioned this pull request Nov 23, 2022
Merged
@PrinsFrank PrinsFrank mentioned this pull request Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@PrinsFrank @mvorisek @Seldaek
0