Maticx refactor #796
Merged
Maticx refactor #796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
99
to
102
| async enacted(deploymentManager: DeploymentManager): Promise<boolean> { | ||
| return true; | ||
| }, | ||
|
|
There was a problem hiding this comment.
This shouldn't be true unless the proposal was actually created.
|
Can you remove the unrelated commits? |
added 3 commits
July 25, 2023 10:11
74d7d86 to
1fa065c
Compare
kevincheng96
added a commit
that referenced
this pull request
Aug 24, 2023
* Add MATICx as collateral against polygon usdc (#777) * initial migration script to add maticx as collateral for polygon usdc * add verify block * formatting: white spaces removal * Linting fixes (#783) * minor fix * linting fix * Clean up * maticx proposal fixes (#786) * maticx yaml permissions fix * Upgrade git action to use new seacrest (#782) * upgrade git action to use new seacrest * updated asset config values * added description * Fix liquidition bot scenarios * Fix lint * Maticx refactor (#796) * code refactor * lint fix * removed unwanted code * maticx description changes (#798) --------- Co-authored-by: Manoj Patra <manoj9april@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run-scenarios.yaml