CAPO price feed #972
Open
CAPO price feed #972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkcmist
reviewed
Mar 20, 2025
| } | ||
|
|
||
| /** | ||
| * @notice Price for the latest round |
Comment on lines
150
to
163
| * @notice Price for the latest round | ||
| * @return roundId Round id from the underlying price feed | ||
| * @return answer Latest price for the asset in terms of ETH | ||
| * @return startedAt Timestamp when the round was started; passed on from underlying price feed | ||
| * @return updatedAt Timestamp when the round was last updated; passed on from underlying price feed | ||
| * @return answeredInRound Round id in which the answer was computed; passed on from underlying price feed | ||
| **/ | ||
| function latestRoundData() external view returns ( | ||
| uint80 roundId, | ||
| int256 answer, | ||
| uint256 startedAt, | ||
| uint256 updatedAt, | ||
| uint80 answeredInRound | ||
| ) { |
There was a problem hiding this comment.
Suggested change
| * @notice Price for the latest round | |
| * @return roundId Round id from the underlying price feed | |
| * @return answer Latest price for the asset in terms of ETH | |
| * @return startedAt Timestamp when the round was started; passed on from underlying price feed | |
| * @return updatedAt Timestamp when the round was last updated; passed on from underlying price feed | |
| * @return answeredInRound Round id in which the answer was computed; passed on from underlying price feed | |
| **/ | |
| function latestRoundData() external view returns ( | |
| uint80 roundId, | |
| int256 answer, | |
| uint256 startedAt, | |
| uint256 updatedAt, | |
| uint80 answeredInRound | |
| ) { | |
| * @notice Price for the latest round | |
| * @return roundId Round id from the underlying price feed | |
| * @return answer Latest price for the asset in terms of ETH | |
| * @return startedAt Timestamp when the round was started; passed on from underlying price feed | |
| * @return updatedAt Timestamp when the round was last updated; passed on from underlying price feed | |
| * @return answeredInRound Round id in which the answer was computed; passed on from underlying price feed | |
| */ | |
| function latestRoundData() external view returns ( | |
| uint80 roundId, | |
| int256 answer, | |
| uint256 startedAt, | |
| uint256 updatedAt, | |
| uint80 answeredInRound | |
| ) { |
Comment on lines
21
to
23
| * @param snapshotRatio ratio at the time of snapshot | ||
| * @param snapshotTimestamp timestamp at the time of snapshot | ||
| * @param maxYearlyRatioGrowthPercent max yearly growth percent |
There was a problem hiding this comment.
Suggested change
| * @param snapshotRatio ratio at the time of snapshot | |
| * @param snapshotTimestamp timestamp at the time of snapshot | |
| * @param maxYearlyRatioGrowthPercent max yearly growth percent | |
| * @param snapshotRatio Ratio at the time of snapshot | |
| * @param snapshotTimestamp Timestamp at the time of snapshot | |
| * @param maxYearlyRatioGrowthPercent Max yearly growth percent |
Comment on lines
85
to
92
| * @param _manager address of the manager | ||
| * @param _baseAggregatorAddress address of the base aggregator | ||
| * @param _ratioProviderAddress address of the ratio provider | ||
| * @param _description description of the pair | ||
| * @param _ratioDecimals number of decimals for the ratio | ||
| * @param _priceFeedDecimals number of decimals for the price feed | ||
| * @param _minimumSnapshotDelay minimum time that should have passed from the snapshot timestamp to the current block.timestamp | ||
| * @param _priceCapSnapshot parameters to set price cap |
There was a problem hiding this comment.
Suggested change
| * @param _manager address of the manager | |
| * @param _baseAggregatorAddress address of the base aggregator | |
| * @param _ratioProviderAddress address of the ratio provider | |
| * @param _description description of the pair | |
| * @param _ratioDecimals number of decimals for the ratio | |
| * @param _priceFeedDecimals number of decimals for the price feed | |
| * @param _minimumSnapshotDelay minimum time that should have passed from the snapshot timestamp to the current block.timestamp | |
| * @param _priceCapSnapshot parameters to set price cap | |
| * @param _manager Address of the manager | |
| * @param _baseAggregatorAddress Address of the base aggregator | |
| * @param _ratioProviderAddress Address of the ratio provider | |
| * @param _description Description of the pair | |
| * @param _ratioDecimals Number of decimals for the ratio | |
| * @param _priceFeedDecimals Number of decimals for the price feed | |
| * @param _minimumSnapshotDelay Minimum time that should have passed from the snapshot timestamp to the current block.timestamp | |
| * @param _priceCapSnapshot Parameters to set price cap |
|
|
||
| /** | ||
| * @notice Updates price cap parameters | ||
| * @param priceCapParams parameters to set price cap |
There was a problem hiding this comment.
Suggested change
| * @param priceCapParams parameters to set price cap | |
| * @param priceCapParams Parameters to set price cap |
|
|
||
| /** | ||
| * @notice Updates price cap parameters from recent snapshot | ||
| * @param priceCapParams parameters to set price cap |
There was a problem hiding this comment.
Suggested change
| * @param priceCapParams parameters to set price cap | |
| * @param priceCapParams Parameters to set price cap |
Comment on lines
16
to
23
| * @param _manager address of the manager | ||
| * @param _baseAggregatorAddress address of the base aggregator | ||
| * @param _ratioProviderAddr 8000 ess address of the ratio provider | ||
| * @param _description description of the pair | ||
| * @param _ratioDecimals number of decimals for the ratio | ||
| * @param _priceFeedDecimals number of decimals for the price feed | ||
| * @param _minimumSnapshotDelay minimum time that should have passed from the snapshot timestamp to the current block.timestamp | ||
| * @param _priceCapSnapshot parameters to set price cap |
There was a problem hiding this comment.
Suggested change
| * @param _manager address of the manager | |
| * @param _baseAggregatorAddress address of the base aggregator | |
| * @param _ratioProviderAddress address of the ratio provider | |
| * @param _description description of the pair | |
| * @param _ratioDecimals number of decimals for the ratio | |
| * @param _priceFeedDecimals number of decimals for the price feed | |
| * @param _minimumSnapshotDelay minimum time that should have passed from the snapshot timestamp to the current block.timestamp | |
| * @param _priceCapSnapshot parameters to set price cap | |
| * @param _manager Address of the manager | |
| * @param _baseAggregatorAddress Address of the base aggregator | |
| * @param _ratioProviderAddress Address of the ratio provider | |
| * @param _description Description of the pair | |
| * @param _ratioDecimals Number of decimals for the ratio | |
| * @param _priceFeedDecimals Number of decimals for the price feed | |
| * @param _minimumSnapshotDelay Minimum time that should have passed from the snapshot timestamp to the current block.timestamp | |
| * @param _priceCapSnapshot Parameters to set price cap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.