8000 WOOF! Software USDC stream by dmitriy-woof-software · Pull Request #985 · compound-finance/comet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

WOOF! Software USDC stream #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

WOOF! Software USDC stream #985

wants to merge 17 commits into from

Conversation

dmitriy-woof-software
Copy link
Contributor

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems May 10, 2025
View reviewed changes
contracts/Streamer.sol
Comment on lines +74 to +80
constructor(address _receiver) {
if(_receiver == address(0)) revert ZeroAddress();

compOracleDecimals = AggregatorV3Interface(COMP_ORACLE).decimals();
usdcOracleDecimals = AggregatorV3Interface(USDC_ORACLE).decimals();
10000 receiver = _receiver;
}

Check notice

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.non-payable-constructor Note

Consider making costructor payable to save gas.
contracts/Streamer.sol
Comment on lines +100 to +103
if(
msg.sender != receiver &&
block.timestamp < lastClaimTimestamp + 7 days
) revert NotReceiver();

Check notice

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-nested-if Note

Using nested is cheaper than using && multiple check combinations.
There are more advantages, such as easier to read code and better coverage reports.
contracts/Streamer.sol
}

lastClaimTimestamp = block.timestamp;
suppliedAmount += owed;

Check notice

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.inefficient-state-variable-increment Note

+= costs more gas than = + for state variables.
contracts/Streamer.sol

lastClaimTimestamp = block.timestamp;
suppliedAmount += owed;
claimedCompAmount += compAmount;

Check notice

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.inefficient-state-variable-increment Note

+= costs more gas than = + for state variables.
github-advanced-security[bot]
github-advanced-security bot found potential problems May 10, 2025
View reviewed changes
contracts/Streamer.sol
Comment on lines +130 to +133
if(
msg.sender != COMPOUND_TIMELOCK &&
block.timestamp < startTimestamp + STREAM_DURATION + 10 days
) revert StreamNotFinished();

Check notice

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-nested-if Note

Using nested is cheaper than using && multiple check combinations.
There are more advantages, such as easier to read code and better coverage reports.
@MishaShWoof MishaShWoof force-pushed the woof-software/create-usdc-stream branch from 90ec56c to 1a4acd7 Compare May 15, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmitriy-woof-software @MishaShWoof
0