8000 Use immutable for Multicall by cwang25 · Pull Request #171 · compound-finance/quark · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use immutable for Multicall #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 1, 2024
Merged

Use immutable for Multicall #171

merged 3 commits into from
Mar 1, 2024

Conversation

cwang25
Copy link
Contributor
@cwang25 cwang25 commented Feb 28, 2024

No description provided.

hayesgm
hayesgm reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor
@hayesgm hayesgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so much better!

kevincheng96
kevincheng96 reviewed Feb 28, 2024
View reviewed changes
Copy link
Collaborator
@kevincheng96 kevincheng96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, much cleaner now 🧼

@cwang25 cwang25 requested review from hayesgm and kevincheng96 March 1, 2024 04:10
hayesgm
hayesgm approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor
@hayesgm hayesgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

kevincheng96
kevincheng96 approved these changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator
@kevincheng96 kevincheng96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor suggestion

@cwang25 @kevincheng96
Update src/quark-core-scripts/src/Multicall.sol
edeecc1 
Co-authored-by: Kevin Cheng <kevincheng96@hotmail.com>
@cwang25 cwang25 merged commit 89d57b6 into main Mar 1, 2024
@cwang25 cwang25 deleted the hans/remove-slots branch March 1, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hayesgm hayesgm hayesgm approved these changes

@kevincheng96 kevincheng96 kevincheng96 approved these changes

@fluffywaffles fluffywaffles Awaiting requested review from fluffywaffles

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cwang25 @hayesgm @kevincheng96
0