seadex-essentials: Bump versions, remove header option force #18318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conan v1 pipeline ✔️All green in build 1 (
Conan v2 pipeline ✔️
All green in build 1 (
|
czoido
approved these changes
Jul 4, 2023
prince-chrismc
approved these changes
Jul 4, 2023
prince-chrismc
suggested changes
Jul 4, 2023
There was a problem hiding this comment.
I am not sure this is the correct place to fix the problem.
#17976 backport patches and breaks spdlog
prince-chrismc
approved these changes
Jul 5, 2023
pezy
pushed a commit
to pezy/conan-center-index
that referenced
this pull request
Jul 15, 2023
SpaceIm
reviewed
Sep 14, 2023
| @@ -48,14 +48,12 @@ def config_options(self): | |||
| def configure(self): | |||
| if self.options.shared: | |||
| self.options.rm_safe("fPIC") | |||
| self.options["fmt/*"].header_only = True | |||
| self.options["spdlog/*"].header_only = True | |||
There was a problem hiding this comment.
This is a bad idea, because now it doesn't build out of the box, and c3i doesn't test this recipe anymore (all configurations raise Invalid Configuration, since this recipe raises when spdlog is not header only).
Raising with default configuration is bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: seadex-essentials/all
Fixes the conflicts from #18134, while also improving simplifying logic that as @czoido pointed out, is no good either way.