8000 Fix bug in BMS Boss contactor cycling · Issue #229 · concordia-fsae/firmware · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Fix bug in BMS Boss contactor cycling #229
Closed
@JoshLafleur

Description

@JoshLafleur

Line 141:142 of 'BMS.c' in bmsb improlerly checks that voltage and timeout. Logic should be
(validmc & validmcvolts) | (valid chrg & valid chgvolts). Presently, a old reported voltage which is above the precharge ratio with the other message sending a low voltage would allow you to cycle states.

Metadata

Metadata

Assignees

Labels

BMSBTracker for all BMSB TicketsbugSomething isn't workinggood first issueGood for newcomers

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    0