User/lz/vcfr pin config fix #194
Conversation
|
continued pr #172 |
39bd31d to
32b665d
Compare
| HW_GPIO_TACH_WHEELSPEED_R, | ||
| HW_GPIO_TACH_WHEELSPEED_L, | ||
| HW_GPIO_RUN_BUTTON, | ||
| HW_GPIO_COUNT, |
There was a problem hiding this comment.
this is not resolved, there is still a space missing. Dont repush if its just this but only resolve when you actually fix it
| [HW_GPIO_ADC_BOARD_TEMP] = { | ||
| .port = GPIOB, | ||
| .pin = GPIO_PIN_1, | ||
| .mode = GPIO_MODE_ANALOG, | ||
| .speed = GPIO_SPEED_FREQ_LOW, | ||
| .pull = GPIO_NOPULL, | ||
| .resetState = HW_GPIO_NOSET, | ||
| }, |
There was a problem hiding this comment.
I dont see this on the schematic, let alone I cannot find a board temp sensor on any of the schematics...
There was a problem hiding this comment.
You still did not fix the name?...
| HW_GPIO_SPI_NCS_IMU, | ||
| HW_GPIO_SPI_NCS_SD, |
There was a problem hiding this comment.
Nit: space at the end
There was a problem hiding this comment.
this is not resolved, there is still a space. Dont repush if its just this but only resolve when you actually fix it
| HW_GPIO_RUN_BUTTON, // WAS RUN | ||
| HW_GPIO_COUNT, | ||
| } HW_GPIO_pinmux_E; | ||
|
|
There was a problem hiding this comment.
Same as other comments. Dont resolve unless you fix it or answer
| HW_GPIO_SPI_NCS_IMU, | ||
| HW_GPIO_SPI_NCS_SD, |
There was a problem hiding this comment.
this is not resolved, there is still a space. Dont repush if its just this but only resolve when you actually fix it
| HW_GPIO_TACH_WHEELSPEED_R, | ||
| HW_GPIO_TACH_WHEELSPEED_L, | ||
| HW_GPIO_RUN_BUTTON, | ||
| HW_GPIO_COUNT, |
There was a problem hiding this comment.
this is not resolved, there is still a space missing. Dont repush if its just this but only resolve when you actually fix it
| HW_GPIO_RUN_BUTTON, // WAS RUN | ||
| HW_GPIO_COUNT, | ||
| } HW_GPIO_pinmux_E; | ||
|
|
There was a problem hiding this comment.
Same as other comments. Dont resolve unless you fix it or answer
|
|
||
| typedef enum | ||
| { | ||
| HW_GPIO_DIG_SPARE1 = 0U, | ||
| HW_GPIO_DIG_SPARE2, | ||
| HW_GPIO_DIG_SPARE3, | ||
| HW_GPIO_DIG_SPARE4, | ||
| HW_GPIO_LED, | ||
| HW_GPIO_ADC_SPARE1, | ||
| HW_GPIO_ADC_SPARE2, | ||
| HW_GPIO_ADC_SPARE3, | ||
| HW_GPIO_ADC_SPARE4, | ||
| HW_GPIO_ADC_APPS_P1, | ||
| HW_GPIO_ADC_APPS_P2, | ||
| HW_GPIO_ADC_BR_POT, | ||
| HW_GPIO_ADC_L_SHK_DISP, | ||
| HW_GPIO_ADC_L_BR_TEMP, | ||
| HW_GPIO_ADC_R_SHK_DISP, | ||
| HW_GPIO_ADC_R_BR_TEMP, | ||
| HW_GPIO_ADC_PU1, | ||
| HW_GPIO_ADC_PU2, | ||
| HW_GPIO_ADC_BR_PR, | ||
| HW_GPIO_ADC_BOARD_TEMP, | ||
| HW_GPIO_5V_NFLT2, //N implies active low | ||
| HW_GPIO_5V_NEN2, | ||
| HW_GPIO_5V_NEN1, | ||
| HW_GPIO_5V_NFLT1, | ||
| HW_GPIO_CAN2_RX, | ||
| HW_GPIO_CAN2_TX, | ||
| HW_GPIO_MUX_SEL2, | ||
| HW_GPIO_MUX_SEL1, | ||
| HW_GPIO_HORN_EN, | ||
| HW_GPIO_BMS_LIGHT_EN, | ||
| HW_GPIO_IMD_LIGHT_EN, 685C | ||
| HW_GPIO_TSSI_G_EN, | ||
| HW_GPIO_TSSI_R_EN, | ||
| HW_GPIO_BR_LIGHT_EN, | ||
| HW_GPIO_CAN1_RX, | ||
| HW_GPIO_CAN1_TX, | ||
| HW_GPIO_MCU_UART_EN, | ||
| HW_GPIO_MCU_UART_TX, | ||
| HW_GPIO_MCU_UART_RX, | ||
| HW_GPIO_SPI_NCS_IMU, | ||
| HW_GPIO_SPI_NCS_SD, |
There was a problem hiding this comment.
Same comments as other pin def
| [HW_GPIO_ADC_BOARD_TEMP] = { | ||
| .port = GPIOB, | ||
| .pin = GPIO_PIN_1, | ||
| .mode = GPIO_MODE_ANALOG, | ||
| .speed = GPIO_SPEED_FREQ_LOW, | ||
| .pull = GPIO_NOPULL, | ||
| .resetState = HW_GPIO_NOSET, | ||
| }, |
There was a problem hiding this comment.
You still did not fix the name?...
| .resetState = HW_GPIO_PINSET, | ||
| }, | ||
| [HW_GPIO_CAN2_RX] = { | ||
| .port = GPIOB, | ||
| .pin = GPIO_PIN_12, | ||
| .mode = GPIO_MODE_INPUT, | ||
| .speed = GPIO_SPEED_FREQ_HIGH, | ||
| .speed = GPIO_SPEED_FREQ_LOW, |
There was a problem hiding this comment.
you resolved and didnt do anything about it or comment on this
| @@ -41,14 +221,183 @@ const HW_GPIO_S HW_GPIO_pinmux[HW_GPIO_COUNT] = { | |||
| .mode = GPIO_MODE_AF_PP, | |||
| .speed = GPIO_SPEED_FREQ_HIGH, | |||
| .pull = GPIO_NOPULL, | |||
| .resetState = HW_GPIO_PINSET, | |||
| .resetState = HW_GPIO_PINRESET, | |||
There was a problem hiding this comment.
you resolved and didnt do anything about it or comment on this
| .port = GPIOD, | ||
| .pin = GPIO_PIN_14, | ||
| .mode = GPIO_MODE_OUTPUT_PP, | ||
| .speed = GPIO_SPEED_FREQ_HIGH, |
There was a problem hiding this comment.
even if we pwm itll sbe low freq. also, you didnt change it...
bf06bb7 to
dede1d2
Compare
64e4152 to
7544124
Compare
7544124 to
e8718e1
Compare
Describe changes
Configured pins for the VC rear from the header.
Set frequency speeds.
Set ports.
Set pins.
Set reset states.
Set GPIO modes
Impact
Configured pins to be used in hopes to have smooth operation and integration later.
Prevent hardware malfunctions and communication errors.
Test Plan