8000 Cleans up BMSB GPIO config by Gray-man · Pull Request #200 · concordia-fsae/firmware · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Cleans up BMSB GPIO config #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Cleans up BMSB GPIO config #200

wants to merge 2 commits into from

Conversation

Gray-man
Copy link
Contributor
@Gray-man Gray-man commented Apr 8, 2025

Describe changes

  1. Added preprocessor guards to GPIO pin definition and initialization files according to build config IDs
    2. 8000
  2. Made diffs easier to review

Impact

  1. Adds new BMSB GPIO configuration for CFR25 platform PCBA ID
  2. Removes setting of IMD_STATUS pin for config ID 1

Test Plan

  • Flash BMSB with CFR24 binary (build config 0)
  • Connect the OK_HS pin on the BMSB to 10V, then to 0V to simulate an IMD fault
  • Ensure that the BMSB acknowledges that an IMD fault has occurred

@Gray-man
Cleans up BMSB GPIO config
a0247b1 
Cleans up BMSB GPIO config PR to make it easier to review
joshlafleur-zip
joshlafleur-zip previously approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor
@joshlafleur-zip joshlafleur-zip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didnt go over the pinout doc, but all these changes look super good and clean. theres only the small cleanliness aspect of HW_GPIO_COUNT but lgtm. Upto you if you want to merge or make that fixup

components/bms_boss/HW/include/HW_gpio_componentSpecific.h Outdated
Comment on lines 34 to 45
HW_GPIO_COUNT,
#endif
#if BMSB_CONFIG_ID == 1U
HW_GPIO_UART_TX_3V,
HW_GPIO_UART_RX_3V,
HW_GPIO_ADC_TEMP,
HW_GPIO_VPACK_ADC_P,
HW_GPIO_VPACK_ADC_N,
HW_GPIO_VPACK_DIAG,
HW_GPIO_CAN2_RX,
HW_GPIO_CAN2_TX,
HW_GPIO_COUNT,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: HW_GPIO_COUNT Could have been left outside the second #if. Minor thing but can also be done down the line I dont find it necessary to repush just for this but can be done for cleanliness. Then youd only need it there once

JoshLafleur
JoshLafleur previously approved these changes Apr 10, 2025
View reviewed changes
@Gray-man
Add HW_GPIO_COUNT to end of list
0d6da0e 
Adds HW_GPIO_COUNT to end of enum for less redundancy
@Gray-man Gray-man dismissed stale reviews from JoshLafleur and joshlafleur-zip via 0d6da0e April 11, 2025 04:48
JoshLafleur
JoshLafleur reviewed Apr 11, 2025
View reviewed changes
Copy link
Collaborator
@JoshLafleur JoshLafleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixup last commit so your pr is only 1 commit and repush. Ill approve right away

JoshLafleur
JoshLafleur approved these changes Apr 11, 2025
View reviewed changes
Copy link
Collaborator
@JoshLafleur JoshLafleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving if you just want to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshLafleur JoshLafleur JoshLafleur approved these changes

@joshlafleur-zip joshlafleur-zip joshlafleur-zip left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gray-man @JoshLafleur @joshlafleur-zip
0