8000 Precharge Timer creation to prevent early precharge termination by LucasZahlan · Pull Request #228 · concordia-fsae/firmware · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Precharge Timer creation to prevent early precharge termination #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2025
Merged

Precharge Timer creation to prevent early precharge termination #228

merged 1 commit into from
May 24, 2025

Conversation

LucasZahlan
Copy link
Contributor
@LucasZahlan LucasZahlan commented Apr 16, 2025 •
edited
Loading

Describe changes

  • Implemented a timer with the minimum time constant to the BMS boss.

Impact

  • Prevent BMS boss precharge termination early by implementing a minimum time before closing contactors.

Test Plan

To test for stuck contractors:

  • Request the contractor to close.
  • Measure voltage across the contractor from + to - of the DC link.

A low measured voltage indicated a stuck open contractor. This test can (and is recommended to) be done on a test bench with our BMS board, 12/24V power to drive the coils, dummy HV circuit or resistor coils, multimeter.

@LucasZahlan LucasZahlan requested a review from JoshLafleur April 16, 2025 00:06
@LucasZahlan LucasZahlan force-pushed the bms_precharge_lockout branch from 3cd2acd to f47d9cf Compare April 16, 2025 00:14
@LucasZahlan LucasZahlan removed the request for review from JoshLafleur April 16, 2025 00:22
JoshLafleur
JoshLafleur reviewed Apr 16, 2025
View reviewed changes
@JoshLafleur
Copy link
Collaborator

Also your test plan isnt descriptive enough. What are the steps to testing precharge termination? Can this be done on the testbench or does it need to be the vehicle? What are the edge cases that should be tested?

@LucasZahlan LucasZahlan force-pushed the bms_precharge_lockout branch from f47d9cf to 4cc0aa7 Compare May 14, 2025 23:50
@LucasZahlan LucasZahlan requested a review from JoshLafleur May 14, 2025 23:52
@LucasZahlan LucasZahlan force-pushed the bms_precharge_lockout branch from 4cc0aa7 to 7939fff Compare May 16, 2025 01:19
JoshLafleur
JoshLafleur reviewed May 22, 2025
View reviewed changes
@LucasZahlan LucasZahlan force-pushed the bms_precharge_lockout branch from 7939fff to cc52707 Compare May 24, 2025 21:22
@LucasZahlan LucasZahlan requested a review from JoshLafleur May 24, 2025 21:26
JoshLafleur
JoshLafleur reviewed May 24, 2025
View reviewed changes
Copy link
Collaborator
@JoshLafleur JoshLafleur left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need a rebase onto master after your last merge. Otherwise lgtm

@LucasZahlan LucasZahlan force-pushed the bms_precharge_lockout branch from bb1439a to f445cef Compare May 24, 2025 22:05
@LucasZahlan LucasZahlan enabled auto-merge May 24, 2025 22:07
@LucasZahlan LucasZahlan merged commit 28c928b into master May 24, 2025
4 checks passed
@LucasZahlan LucasZahlan deleted the bms_precharge_lockout branch May 24, 2025 22:10
@JoshLafleur JoshLafleur linked an issue May 29, 2025 that may be closed by this pull request
Add precharge lockout #188
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshLafleur JoshLafleur JoshLafleur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add precharge lockout
2 participants
@LucasZahlan @JoshLafleur
0